Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rose and Cylc from the ESMValTool environment #3723

Open
ehogan opened this issue Jul 19, 2024 · 2 comments
Open

Remove Rose and Cylc from the ESMValTool environment #3723

ehogan opened this issue Jul 19, 2024 · 2 comments
Assignees
Labels
Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow
Milestone

Comments

@ehogan
Copy link
Contributor

ehogan commented Jul 19, 2024

I have just discovered that installing Rose and Cylc into the ESMValTool environment causes issues if Rose and Cylc are already centrally installed at a site (as is the case for JASMIN and the MO).

Rose and Cylc were introduced into the ESMValTool environment via #3625 for the purposes of the GitHub workflow check-rtw.yml, and also to make it easier for users to run the RTW (see #3625 (comment)).

Originally, the GitHub workflow used its own lock file, containing what was needed for Rose and Cylc to perform the checks. However, @valeriupredoi wasn't keen on this, see #3210 (comment).

I'm not sure how to proceed. Rose and Cylc must be removed from the ESMValTool environment, but what would be the best way to continue running the RTW checks via a GitHub workflow? 🤔

@ehogan ehogan added the Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow label Jul 19, 2024
@ehogan ehogan added this to the v2.12.0 milestone Jul 19, 2024
@ehogan ehogan self-assigned this Jul 19, 2024
@valeriupredoi
Copy link
Contributor

you can set up a local requirements.txt requirements file in the RTW repo, Emma, and when installing the RTW-specific branch you can add an extra step pip install -r requirements.txt run inside the repo where the requirements.txt file is

@valeriupredoi
Copy link
Contributor

Note, however, that my comment you quote was all about not having a lock file there, not that I have something against rose and cylc as deps - they should be fine, especially since they are fairly light on their secondary deps they pull in (since I remember asking you about that at the workshop hehe) 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Recipe Test Workflow (RTW) Items relevant to the Recipe Test Workflow
Projects
None yet
Development

No branches or pull requests

2 participants