Add TropFlux CMORiser #3863
Open
Add TropFlux CMORiser #3863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valeriupredoi
requested changes
Jan 16, 2025
There was a problem hiding this comment.
cheers @rbeucher looking good from a technical stand point - will approve when you add the dataset to the check obs recipe 😁
flicj191
requested changes
Jan 22, 2025
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
|
I believe this is good to go @flicj191 ? |
flicj191
requested changes
Jan 30, 2025
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
Co-authored-by: Felicity Chun <[email protected]>
flicj191
approved these changes
Jan 30, 2025
|
Thanks @flicj191 |
|
Hi @valeriupredoi, would you mind having a quick look? This should be good to go. Thanks! |
valeriupredoi
approved these changes
Feb 5, 2025
| from esmvaltool.cmorizers.data import utilities as utils | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
|
|
There was a problem hiding this comment.
Suggested change
| # scitools-iris.readthedocs.io/en/stable/generated/api/iris.html#iris.Future |
There was a problem hiding this comment.
prob best to add a pointer why using that flag (also, the link may be >79 chars long)
|
also, how is this data gonna live? Will we have to add it to the data pool or you guys doing that? Ping @axel-lauer on this one as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces CMORizers for the TropFlux dataset to enable the processing of its variables for use within ESMValTool.
Global Attributes
Dataset ID: TROPFLUX
Project ID: OBS6
Tier: 2
Version: v1
Modeling Realm: reanaly
Source: https://incois.gov.in/tropflux/
Reference: tropflux
Variables CMORised
The following variables, with their corresponding CMOR tables, are included in this implementation:
ts (Amon): Derived from t2m
tos (Omon): Derived from sst
hfls (Lmon/CFmon): Derived from lhf
rlut (Amon): Derived from lwr
tau (Omon): Derived from tauy
rsds (Amon): Derived from swr
TropFlux provides air-sea flux estimates over the tropics and is widely used for evaluating tropical climate processes like ENSO. Since the CLIVAR package already utilizes TropFlux for ENSO diagnostics, including it in ESMValTool ensures compatibility and allows meaningful cross-framework comparisons.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated data reformatting script
To help with the number of pull requests: