Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframe regression with tolerances for numeric and not just float values #92

Open
HikingDev opened this issue Apr 13, 2022 · 3 comments

Comments

@HikingDev
Copy link

Currently the check performed on numeric values checks if the obtained column dtype is of subtype np.inexact.
This excludes tolerances for Integer values. Is there any specific reason to exclude Integers?

E.g. the type of a column is Int64 and the unit (not shown of course) is nanoseconds, the tolerance check is excluded.

Rather than dataframe_regression#L127

np.issubdtype(obtained_column.values.dtype, np.number)

@nicoddemus
Copy link
Member

nicoddemus commented Apr 13, 2022

cc @tadeu @tarcisiofischer

@tarcisiofischer
Copy link
Contributor

AFAIR, it was because we only used for floats... Feel free to add it, though. Sounds like a good idea to me

@seanv507
Copy link
Contributor

rather than doing this, what about supporting pandas assert_frame_equal: https://pandas.pydata.org/docs/reference/api/pandas.testing.assert_frame_equal.html ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants