Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templated ticker type for callback timers #941

Open
Sedictious opened this issue Aug 2, 2024 · 3 comments
Open

Add templated ticker type for callback timers #941

Sedictious opened this issue Aug 2, 2024 · 3 comments
Assignees

Comments

@Sedictious
Copy link

Currently the callback timers support a fixed timer type of uint32_t which fixes the resolution. I think it would be useful to add a template parameter to allow for configurable timer size.

I was thinking about adding something like timer_size along the lines of what is supported for etl::queue with memory_model which could default to uin32_t, thus not breaking any backwards compatibility. Would that be something of interest or is there any limiting factor I am missing?

@jwellbelove
Copy link
Contributor

I'll take a look and see if it's viable.

@jwellbelove jwellbelove self-assigned this Aug 2, 2024
@Sedictious
Copy link
Author

@jwellbelove I am dealing with the change locally so it would be possible for me to clean up and and prepare a PR following the style of memory_model if it would help

@jwellbelove
Copy link
Contributor

OK, give it a go. I'll be interested in what you come up with.
Don't forget there are multiple timer classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants