Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python3.6 #122

Open
muccix opened this issue Mar 20, 2017 · 11 comments
Open

Support for Python3.6 #122

muccix opened this issue Mar 20, 2017 · 11 comments

Comments

@muccix
Copy link

muccix commented Mar 20, 2017

Does the library support Python 3.6?

We are going to relay on this library in the B2STAGE HTTP-API which is based on py 3.6

Thanks!

@cookie33
Copy link

Hi,

It is tested against python 3.5: https://jenkins.argo.grnet.gr/job/B2HANDLE_devel/

The documentation also states python 3.5

@muccix
Copy link
Author

muccix commented Mar 20, 2017

Let me try to reformulate the question: do you have plan for supporting python 3.6?

Many thanks

@SofianeB
Copy link
Contributor

The solution proposed in (#115) does not resolve the random dictionary order issue in python 3.6..

@muccix
Copy link
Author

muccix commented Mar 21, 2017

Does the issue affect only the tests? If that is the case we could start using the library anyway (maybe forking and editing the setup.py)

@SofianeB
Copy link
Contributor

I just performed some operations like creating and retrieving handles (python 3.6.0) and it works.
The issue concerns only the testcase "test_create_revlookup_query_normal_checksum_and_url".

@muccix
Copy link
Author

muccix commented Mar 21, 2017

Ok. I have forked the repo here.
Just for the record: I couldn't install with pip3 install b2handle-1.1.1-py3.6.egg receiving the error:

Collecting b2handle-1.1.1-py3.6.egg
  Could not find a version that satisfies the requirement b2handle-1.1.1-py3.6.egg (from versions: )
No matching distribution found for b2handle-1.1.1-py3.6.egg

It worked with easy_install b2handle-1.1.1-py3.6.egg

I leave you the choice whether to close the issue. Thanks!

@TobiasWeigel
Copy link
Contributor

Just talked again with Sofiane and we think that the dictionary ordering issue is a Python issue that has already been discussed in the community for quite a while now. But this does not affect the functionality of b2handle; so our solution is to deactivate the test.
This could then go together with configured support for Py3.6 and further testing into one of the next releases. Currently, the splitting of the library / pyhandle development takes priority.

@raphael-ritz
Copy link

I admit I'm missing context here but if the core of the problem is that comparing dicts may yield failures because the order is undefined why not use cmp instead of ==. Or use an OrderedDict (from collections) to begin with.

Just my 2 cents,

Raphael - a lurker

pmontepagano added a commit to BibliotecaLeloir/B2HANDLE that referenced this issue Mar 1, 2018
@stefan-wolfsheimer
Copy link

I wonder if there is any progress on this?
Does the fork of @muccix solve this issue?
Would it make sense to merge it back to the main project?

@SofianeB
Copy link
Contributor

@stefan-wolfsheimer we will release a new version of the B2HANDLE library that supports Python 3.6. / 3.7

@avbentem
Copy link

Meanwhile, the October 2019 256b5a9 says:

The library currently supports Python 2.6, 2.7, 3.5, 3.6 and 3.7, and requires at least a Handle System server 8.1.

It seems this was also merged into the October 2019 pre-release 1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants