Split run_pywake function into focused helper functions#40
Open
bjarketol wants to merge 4 commits intoEUFLOW:mainfrom
Open
Split run_pywake function into focused helper functions#40bjarketol wants to merge 4 commits intoEUFLOW:mainfrom
bjarketol wants to merge 4 commits intoEUFLOW:mainfrom
Conversation
Removed unused imports from pywake_api.py: - matplotlib.pyplot as plt - pandas as pd - NOJ, BastankhahGaussian, HorizontalGrid from py_wake - CGIRotorAvg, EqGridRotorAvg, GaussianOverlapAvgModel, GQGridRotorAvg, PolarGridRotorAvg, polar_gauss_quadrature from rotor_avg_models - PowerCtFunctions from power_ct_functions Removed unused import from main_api.py: - import yaml Deleted commented-out code blocks: - Old farm/resource loading code (~13 lines) - Commented XRSite construction (~6 lines) - Old output directory logic (~5 lines) - Old AEP printing (~2 lines) - Power percentile calculation block (~21 lines) - Flow map and power table comments (~13 lines) - Duplicate YAML output code (~40 lines) - Various debug/TODO comments throughout
Member
|
But tests fail now? |
Contributor
Author
|
@kilojoules yeah, I will fix that, didn't get around to it yet. |
The foxes package does not export reset_engine. Removed the import and its usage in the error handler, keeping the engine = None reset. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
@kilojoules Now the tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The monolithic run_pywake() function (~928 lines) is now ~59 lines that orchestrate calls to focused helper functions.