You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
I want to emulate several upstream response with cache-control header. As you know cache-control policy can have several values with "," as a delimiter.
Example:
Cache-Control: max-age=300, public.must-revalidate
Current the code is splitting the custom headers with "," and the proposal is to switch to ";" in order to support several values on a header
To Reproduce
X-ECHO-HEADER=Cache-Control: max-age=300, public; One: 1
Expected behavior
The response should have the following headers:
Cache-Control: max-age=300, public
One: 1
Additional context
I can open a PR if you want to fix this issue
The text was updated successfully, but these errors were encountered:
Hello ! Thanks for this issue. You're right! It's probably better to have configuration about that. The first reason is the potential breaking change... What do you think about that ?
I have to maintain this repository and the related Helm chart, I planned to do it this weekend or in few weeks. So, as you want 🤷♂️
You may control the breaking change, but it will add extra complexity. For instance, you can support the split by "," but you need to guarantee that the next item should be something [a-zA-z]: that is the only way to support the current behaviour.
IMHO, you can launch a major change and avoid that complexity and put your service working as expected.
Describe the bug
I want to emulate several upstream response with cache-control header. As you know cache-control policy can have several values with "," as a delimiter.
Example:
Cache-Control: max-age=300, public.must-revalidate
Current the code is splitting the custom headers with "," and the proposal is to switch to ";" in order to support several values on a header
To Reproduce
X-ECHO-HEADER=Cache-Control: max-age=300, public; One: 1
Expected behavior
The response should have the following headers:
Cache-Control: max-age=300, public
One: 1
Additional context
I can open a PR if you want to fix this issue
The text was updated successfully, but these errors were encountered: