Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally accept solana style key.json instead of a public address #36

Open
dlin128 opened this issue Jul 30, 2024 · 0 comments
Open

Comments

@dlin128
Copy link
Member

dlin128 commented Jul 30, 2024

Added benefit here is that we ensure the user has the key that they are intending to send to on Eclipse. Account address is derived from provide key.json.

0xObsidian added a commit to 0xObsidian/eclipse-deposit that referenced this issue Dec 17, 2024
Description
-----------
- introduced --solana-key flag
- added support for reading Solana keypair files
  and deriving public keys
- implemented validation to prevent using both
  --solana-key and --destination
- added test suite for the introduced feat
- improved error handling for invalid key files

Usage
-----
Clone this PR branch and install dependencies and make sure you
followed the readme to derive eth key `private-key.txt`
and solana key `key.json` and then run
```
node bin/cli.js -k private-key.txt --solana-key key.json -a 0.002 --sepolia
```

Testing the introduced feat
---------------------------
From the root direcoty, run:
```
yarn test
```

This PR closes ticket Eclipse-Laboratories-Inc#36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant