Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old observations updated without substantive changes are changed to Purple #88

Open
nigelcharman opened this issue Mar 12, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@nigelcharman
Copy link
Contributor

The observations were originally RED. They had additional detail added to Weed Management Aotearoa NZ observation fields, but without the Date Controlled or Date of Status Update being set.

The status should have stayed RED but was changed to PURPLE.

See logs in https://github.com/EcoNet-NZ/inaturalist-to-cams/actions/runs/7951343326/job/21704656554 for details of the fields.

The issue seems to arise from translator.py:

        if visit_date < start_of_this_weed_year:
            visit_status = 'PURPLE'
@nigelcharman nigelcharman added the bug Something isn't working label Mar 12, 2024
@nigelcharman
Copy link
Contributor Author

I'm not sure why these are updating the existing weed visit to Purple rather than creating a new weed visit?
Additional examples are weed instance 61124 and 61125.

@nigelcharman nigelcharman self-assigned this Jan 5, 2025
@nigelcharman
Copy link
Contributor Author

It's updating the existing weed visit row since the date hasn't changed.
Options to resolve this issue include:

  1. Never set PURPLE status from the iNaturalist sync process
  2. Only set PURPLE status on the initial synchonisation

The reason we are setting PURPLE currently is that we don't know the status of the observation. It may be years old and so we set it to PURPLE (needs checking).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant