Load More persisting when no more issues load

[amandamartin-dev]

Description

The load more button will persist even when there are no more issues loading and takes multiple clicks to hide.

This issue is potentially related to #295 as Load More appears to persist and populate more filters but no new issue cards. (video attached below)

Steps to repro
Login to finder
toggle to github
search for javascript
click load more - no more issues populate, but checkboxes update
click load more again - same as above
click load more a 3rd time - hides as expected

Proposed solution: Load more should hide/show based on available issues (unlink from filter updating)

Screenshots

loadmore.mov

Additional information

No response

[Cahllagerfeld]

I think this behavior is caused by the implementation of the filter: It's just client-side not applying to the search query that's run against Github:

All Issues that are returned are filtered on the Client-Side for "JavaScript", you can keep loading more and more issues, that aren't displayed, because the ones that are loaded don't match the filter.

When applying a filter to the issues, we don't know if there are more issues to load that match that filter, because as I said it's solely on the Client.

A possible workaround might be hiding the "Load more" in case a filter gets applied

Does this make sense? 😅

[amandamartin-dev]

Oh interesting. Yes, it makes sense.

With a filter applied do you think there is ever a situation where "Load More" will be needed? If not, then yes hiding on filter makes sense. But in the case of a large amount of issues, a load more could be needed there but like you said - it wouldn't "know" how many more so would have to figure that part out too.

When I have some time I can take a look at the code too and see if I can think of any other ideas.

[yuviS003]

Hey amandamartin-dev
Please assign this issue to me. I can fix it.

Edit: I want to resolve a number of issues in this repo but for some reason after hitting 'Login with GitHub' button I get an error saying 'CSRF token not matching'. I have followed exact steps in the contributions guide. Can somebody please help me out?

[Cahllagerfeld]

Based on the CSRF issue I assume something with the Github-App isn't working as expected. Did you configure the Oauth app to point to your dev-environment and the correct endpoint?

[yuviS003]

Great, thanks for the help Cahllagerfeld

[tbhaxor]

I think this behavior is caused by the implementation of the filter: It's just client-side not applying to the search query that's run against Github:

All Issues that are returned are filtered on the Client-Side for "JavaScript", you can keep loading more and more issues, that aren't displayed, because the ones that are loaded don't match the filter.

When applying a filter to the issues, we don't know if there are more issues to load that match that filter, because as I said it's solely on the Client.

A possible workaround might be hiding the "Load more" in case a filter gets applied

Does this make sense? 😅

Yes, hasNextPage is true, also I tried setting the text in the query. It only works when you enter exact word with same case-sensitivity.

{
  "queryString": "is:open archived:false label:\"EddieHub:good-first-issue\" no:assignee Footer",
  "skip": 10,
  "after": null
}