Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 14, App crash when notification received #201

Open
zabi90 opened this issue Oct 7, 2020 · 13 comments
Open

iOS 14, App crash when notification received #201

zabi90 opened this issue Oct 7, 2020 · 13 comments

Comments

@zabi90
Copy link

zabi90 commented Oct 7, 2020

Hi,
I installed this plug-in in brand new angular share project. When notification received inside app it is crashing. I'm assuming this plug might not update at iOS 14. When app is in background it is show notification.
Thanks

@Philntps
Copy link

i got this issue too

@belugasanity
Copy link

I am also seeing this issue. Works when app is running in background. When app is open the app crashes when the notification is supposed to be received. Also on iOS 14

@georgemark0v
Copy link

any updates?

@rob4226
Copy link

rob4226 commented Jan 7, 2021

@EddyVerbruggen I am also having the same issue where iOS crashes if the notification is scheduled and app is in foreground. Is there a work around at the moment for iOS? Thank you.

@faisalansari20
Copy link

faisalansari20 commented Jan 13, 2021

@EddyVerbruggen . We are also facing same issue. Any update or any work around?

@uidhtml
Copy link

uidhtml commented Jan 16, 2021

@EddyVerbruggen, Please please help on this, this actually big issue with this plugin, coz commonly most of IOS is on 14.0 now and we just lacking the benefit of functionality, please help us.... :(

@EddyVerbruggen
Copy link
Owner

I wish I had the bandwidth to take a look, but maybe it helps to switch to the N7-compatible version (see the top of the repo)? If that doesn't crash then there must be a recent change in that repo which fixes the issue and we can do a simple PR.

@uidhtml
Copy link

uidhtml commented Jan 16, 2021

I wish I had the bandwidth to take a look, but maybe it helps to switch to the N7-compatible version (see the top of the repo)? If that doesn't crash then there must be a recent change in that repo which fixes the issue and we can do a simple PR.

Compitable to NS 7+ as well as Downgraded the v 4.2.1, but got same.. :(, and one more issue could not list, listing now, "The Local Notifications plugin allows your app to show notifications when the app is not running. " app unable to show notifications when we kill app just after scheduling, know you don't have bandwidth, but requesting.. :)

@rob4226
Copy link

rob4226 commented Jan 16, 2021

@uidhtml I feel you, I've been trying to figure this out all week. I'm having a hard time bc there's no errors/exceptions to go off of. Even debugging in xcode all I got was:

->  0x10c74bb79: .long  0x01046c30                ; unknown opcode  Thread 1: EXC_BAD_ACCESS (code=257, address=0x10c74bb79)
    0x10c74bb7d: udf    #0x0
    0x10c74bb81: cmphs  p0.b, p0/z, z0.b, z0.b
    0x10c74bb85: stlur  x0, [x0]
    0x10c74bb89: .long  0x010a78bb                ; unknown opcode
    0x10c74bb8d: str    w0, [x0]
    0x10c74bb91: .long  0x010c9d7c                ; unknown opcode
    0x10c74bb95: str    w0, [x0]

The only thing I can think of is that it has something to do with the userNotificationCenterWillPresentNotificationWithCompletionHandler because that is what gets called when the app is in the foreground.

@uidhtml
Copy link

uidhtml commented Jan 17, 2021 via email

@rob4226
Copy link

rob4226 commented Jan 17, 2021

Thanks Uidhtml. I will keep trying also bc I also really need this.

@uidhtml
Copy link

uidhtml commented Jan 18, 2021 via email

@rob4226
Copy link

rob4226 commented Jan 28, 2021

@EddyVerbruggen @uidhtml So it appears that userNotificationCenterWillPresentNotificationWithCompletionHandler really is where the problem is. I narrowed it down to calling completionHandler() is what crashes the app on iOS. If you don't call it, the app won't crash, but you won't get a notification either. I tried just calling completionHandler(1) or completionHandler(4) but it still crashes right away.

@EddyVerbruggen Do you have any ideas why calling completionHandler() would cause a crash? Thanks!

/**
     * Called when the app is in the foreground.
     */
    userNotificationCenterWillPresentNotificationWithCompletionHandler(center, notification, completionHandler, next) {
        if (notification.request.content.userInfo.valueForKey('__NotificationType') !== 'nativescript-local-notifications' || notification.request.trigger instanceof UNPushNotificationTrigger) {
            next();
            return;
        }
        this.receivedInForeground = true;
        if (notification.request.content.userInfo.valueForKey('forceShowWhenInForeground') || notification.request.content.userInfo.valueForKey('priority')) {
            completionHandler(1 /* Badge */ | 2 /* Sound */ | 4 /* Alert */);
        }
        else {
            completionHandler(1 /* Badge */ | 2 /* Sound */);
        }
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants