Apply all constraints without early exits

We need generators to not early exit on constraints so they're all
applied. This is nice so we don't need to couple our constraints to
other constrains when adding/removing. The contract is that all
the constraints will get equal chance of being applied.

Author: samholmes

src/plugins/ramps/rampConstraints.ts

@@ -13,22 +13,33 @@ export interface RampConstraintParams {
   paymentType: FiatPaymentType
 }
 
-export const validateRampConstraintParams = (
+export function validateRampConstraintParams(
   params: RampConstraintParams
-): boolean => {
+): boolean {
+  for (const constraint of constraintGenerator(params)) {
+    if (!constraint) {
+      return false
+    }
+  }
+  return true
+}
+
+function* constraintGenerator(
+  params: RampConstraintParams
+): Generator<boolean, boolean> {
   // Restrict ACH to only US
   if (params.paymentType === 'ach') {
-    return params.regionCode.countryCode === 'US'
+    yield params.regionCode.countryCode === 'US'
   }
 
   // Venmo payment method is only supported in the USA
   if (params.paymentType === 'venmo') {
-    return params.regionCode.countryCode === 'US'
+    yield params.regionCode.countryCode === 'US'
   }
 
   // Filter out credit for sell in US for Paybis
   if (params.rampPluginId === 'paybis' && params.direction === 'sell') {
-    return params.regionCode.countryCode === 'US'
+    yield params.regionCode.countryCode === 'US'
   }
 
   // Constrain Revolut to the supported regions
@@ -43,7 +54,7 @@ export const validateRampConstraintParams = (
       .replace(/\s/g, '')
       .split(',')
 
-    return forCountries.includes(params.regionCode.countryCode)
+    yield forCountries.includes(params.regionCode.countryCode)
   }
 
   return true