Skip to content

Commit de56e6a

Browse files
authored
Use flexible preloading for oauth image (#85)
* Use flexible preloading for oauth image * Use flexible preloading approach to preload outh proxy image
1 parent 1aa421c commit de56e6a

File tree

7 files changed

+46
-1
lines changed

7 files changed

+46
-1
lines changed

.github/workflows/deploy-theia.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,9 @@ jobs:
379379
)
380380
fi
381381
382-
# Only override IDE images when a tag is explicitly provided
382+
# Only override IDE images when a tag is explicitly provided.
383+
# Indices 0 (landing) and 1-10 (IDE + no-ls + langserver preload) are set above / here.
384+
# Index 11 is oauth2-proxy (distroless); keep it only in values.yaml so it is never replaced by a string override.
383385
if [ -n "${IDE_IMAGES_TAG}" ]; then
384386
HELM_CMD+=(
385387
--set "theia-cloud.preloading.images[1]=ghcr.io/eduide/eduide/java-17:${IDE_IMAGES_TAG}"

charts/theia-cloud-combined/values.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ theia-cloud:
5959
name: service-admin-api-token
6060
key: ADMIN_API_TOKEN
6161

62+
# Preload indices 0–10 align with .github/workflows/deploy-theia.yml tag overrides; 11 = oauth2-proxy (not overridden there).
6263
preloading:
6364
images:
6465
- ghcr.io/eduide/eduidec-landing-page:latest
@@ -68,6 +69,12 @@ theia-cloud:
6869
- ghcr.io/eduide/eduide/ocaml:latest
6970
- ghcr.io/eduide/eduide/rust:latest
7071
- ghcr.io/eduide/eduide/python:latest
72+
- ghcr.io/eduide/eduide/java-17-no-ls:latest
73+
- ghcr.io/eduide/eduide/rust-no-ls:latest
74+
- ghcr.io/eduide/eduide/langserver-java:latest
75+
- ghcr.io/eduide/eduide/langserver-rust:latest
76+
- image: quay.io/oauth2-proxy/oauth2-proxy:v7.12.0
77+
args: ["--version"]
7178

7279
imagePullPolicy: Always
7380

deployments/test1.theia-test.artemis.cit.tum.de/values.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ theia-cloud:
5555
# name: service-admin-api-token
5656
# key: ADMIN_API_TOKEN
5757

58+
# Preload list indices 0–10 must match deploy-theia.yml --set overrides when tags are passed.
59+
# Index 11 is oauth2-proxy (distroless); the workflow does not override it.
5860
preloading:
5961
images:
6062
- ghcr.io/eduide/eduidec-landing-page:latest
@@ -64,6 +66,12 @@ theia-cloud:
6466
- ghcr.io/eduide/eduide/ocaml:latest
6567
- ghcr.io/eduide/eduide/rust:latest
6668
- ghcr.io/eduide/eduide/python:latest
69+
- ghcr.io/eduide/eduide/java-17-no-ls:latest
70+
- ghcr.io/eduide/eduide/rust-no-ls:latest
71+
- ghcr.io/eduide/eduide/langserver-java:latest
72+
- ghcr.io/eduide/eduide/langserver-rust:latest
73+
- image: quay.io/oauth2-proxy/oauth2-proxy:v7.12.0
74+
args: ["--version"]
6775

6876
imagePullPolicy: Always
6977

deployments/test2.theia-test.artemis.cit.tum.de/values.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@ theia-cloud:
5555
# name: service-admin-api-token
5656
# key: ADMIN_API_TOKEN
5757

58+
# Preload list indices 0–10 must match deploy-theia.yml --set overrides when tags are passed.
59+
# Index 11 is oauth2-proxy (distroless); the workflow does not override it.
5860
preloading:
5961
images:
6062
- ghcr.io/eduide/eduidec-landing-page:latest
@@ -64,6 +66,12 @@ theia-cloud:
6466
- ghcr.io/eduide/eduide/ocaml:latest
6567
- ghcr.io/eduide/eduide/rust:latest
6668
- ghcr.io/eduide/eduide/python:latest
69+
- ghcr.io/eduide/eduide/java-17-no-ls:latest
70+
- ghcr.io/eduide/eduide/rust-no-ls:latest
71+
- ghcr.io/eduide/eduide/langserver-java:latest
72+
- ghcr.io/eduide/eduide/langserver-rust:latest
73+
- image: quay.io/oauth2-proxy/oauth2-proxy:v7.12.0
74+
args: ["--version"]
6775

6876
imagePullPolicy: Always
6977

deployments/test3.theia-test.artemis.cit.tum.de/values.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ theia-cloud:
6161
name: service-admin-api-token
6262
key: ADMIN_API_TOKEN
6363

64+
# Preload list indices 0–10 must match deploy-theia.yml --set overrides when tags are passed.
65+
# Index 11 is oauth2-proxy (distroless); the workflow does not override it.
6466
preloading:
6567
images:
6668
- ghcr.io/eduide/eduide-cloud/landing-page:pr-70
@@ -74,6 +76,8 @@ theia-cloud:
7476
- ghcr.io/eduide/eduide/rust-no-ls:pr-70
7577
- ghcr.io/eduide/eduide/langserver-java:pr-70
7678
- ghcr.io/eduide/eduide/langserver-rust:pr-70
79+
- image: quay.io/oauth2-proxy/oauth2-proxy:v7.12.0
80+
args: ["--version"]
7781

7882
imagePullPolicy: Always
7983

deployments/theia-staging.artemis.cit.tum.de/values.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ theia-cloud:
5454
# name: service-admin-api-token
5555
# key: ADMIN_API_TOKEN
5656

57+
# Preload list indices 0–10 must match deploy-theia.yml --set overrides when tags are passed.
58+
# Index 11 is oauth2-proxy (distroless); the workflow does not override it.
5759
preloading:
5860
images:
5961
- ghcr.io/eduide/eduidec-landing-page:latest
@@ -63,6 +65,12 @@ theia-cloud:
6365
- ghcr.io/eduide/eduide/ocaml:latest
6466
- ghcr.io/eduide/eduide/rust:latest
6567
- ghcr.io/eduide/eduide/python:latest
68+
- ghcr.io/eduide/eduide/java-17-no-ls:latest
69+
- ghcr.io/eduide/eduide/rust-no-ls:latest
70+
- ghcr.io/eduide/eduide/langserver-java:latest
71+
- ghcr.io/eduide/eduide/langserver-rust:latest
72+
- image: quay.io/oauth2-proxy/oauth2-proxy:v7.12.0
73+
args: ["--version"]
6674

6775
imagePullPolicy: Always
6876

deployments/theia.artemis.cit.tum.de/values.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ theia-cloud:
5454
# name: service-admin-api-token
5555
# key: ADMIN_API_TOKEN
5656

57+
# Preload list indices 0–10 must match deploy-theia.yml --set overrides when tags are passed.
58+
# Index 11 is oauth2-proxy (distroless); the workflow does not override it.
5759
preloading:
5860
images:
5961
- ghcr.io/eduide/eduidec-landing-page:latest
@@ -63,6 +65,12 @@ theia-cloud:
6365
- ghcr.io/eduide/eduide/ocaml:latest
6466
- ghcr.io/eduide/eduide/rust:latest
6567
- ghcr.io/eduide/eduide/python:latest
68+
- ghcr.io/eduide/eduide/java-17-no-ls:latest
69+
- ghcr.io/eduide/eduide/rust-no-ls:latest
70+
- ghcr.io/eduide/eduide/langserver-java:latest
71+
- ghcr.io/eduide/eduide/langserver-rust:latest
72+
- image: quay.io/oauth2-proxy/oauth2-proxy:v7.12.0
73+
args: ["--version"]
6674

6775
imagePullPolicy: Always
6876

0 commit comments

Comments
 (0)