remove promise hack #293
Open
remove promise hack #293
+3
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatchi
commented
Jul 26, 2022
| } | ||
| }) | ||
| ) | ||
| M.make((p) => T.promise(() => p.shutdown())) |
There was a problem hiding this comment.
Looks like Managed has been removed. What should it be replaced with?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should we also bump the
@opentelemetrypackages to a newer version? It's not clear to me what version fixed the issue. It looks like theshutdownfunction from theSpanExporterinterface has always been returning aPromise. I wanted to refresh my mind about what exactly the issue is but it appears the youtube link of the video you recorded is not available anymore 😅Fixes #285