Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetCurves #628

Open
robert-b opened this issue Jan 17, 2025 · 11 comments
Open

SetCurves #628

robert-b opened this issue Jan 17, 2025 · 11 comments

Comments

@robert-b
Copy link

Recently there has been a fix applied for SetCurves: #291
Unfortunetly it still does not work.
The described json document is wrong and fixing this has not solved the issue.

@geduxas
Copy link
Contributor

geduxas commented Jan 17, 2025

it's not in released firmware yet. so you should need to wait, or test alpha firmware..

@robert-b
Copy link
Author

then it is time to test - as i need this functionality.
thanks for your help.

@IgorYbema
Copy link
Contributor

Sorry but the fix isn't working good enough. It breakes other rules so for now it isn't ready for the next firmware release.

@robert-b
Copy link
Author

surprise

@stumbaumr
Copy link

stumbaumr commented Jan 17, 2025

As far as I understand modifying the heat curves already works since release 3.8.
Sample from my rules:
@SetCurves = concat('{zone1:{heat:{target:{high:', $targetAfterDHW ,',low:', $targetAfterDHW ,'}}}}');

Or am I missing something here?

@robert-b
Copy link
Author

i have no idea - but i can test the snippet.
up to now - nothing has been accepted when saving my rules.

@stumbaumr
Copy link

You can test my rules... the snippet alone will not work...

@robert-b
Copy link
Author

ok - this snippet is bad:
@SetCurves = concat('{"zone1":{"heat":{"target":"high":', @Z1_Heat_Curve_Target_High_Temp, ',"low":', @Z1_Heat_Curve_Target_Low_Temp, '}}}}');

but this:
@SetCurves = concat('{zone1:{heat:{target:{high:', $target ,',low:', $low ,'}}}}');
works
already tested.
my updated script works.
very interesting and thanks a lot.

@stumbaumr
Copy link

So you should be able to close the issue then, right?

@McMagellan
Copy link

I can confirm that SetCurves used in Rules has worked very well without any problems since 3.8.
For example: @SetCurves = concat('{zone1:{heat:{target:{high:',#VLRef,',low:',#VLRef,'}}}}');
Thanks for the implementation.

Are there any considerations about setting up a "Rules Wiki" where you can look up small code examples?

@robert-b
Copy link
Author

i can't close the issue because there is a difference between the actual implementation and the documentation.
both have to be in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants