-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for more flexibility #10
Comments
The framework allow flexible pin definitions. Perhaps we can define the pin definitions by dropdown selection. The project starts with one meter. The additional meters where requested by users. Actually there was no user with more the 4 requested. I don´t know if there is a user with >4 ? |
I've seen the history of the project (at least from the iobroker forum entries) and i saw that someone requested 7 meters (which i think should be possible?) here: https://forum.iobroker.net/topic/35404/ferraris-z%C3%A4hler-mit-tcrt5000-und-esp8266/17?_=1666024770196&lang=de I guess a dropdown allows the configuration to be as flexible for the user as possible, i don't know if there is any input validation on the web stuff though. Yet another construction site that i haven't digged into too much 🙈 |
I started with refactoring, progress can be followed here:
Selection will be at compile time as IOT Framework does not allow dynamic web pages. |
Currently for each new meter we want to add, we do need to add a lot of code.
This should be more flexible in my opinion, as in the easiest case i should only have to raise the number of meters and recompile my firmware (maybe not even that?). Depending on the setup of the pins, we'd have to predefine all possible meter to pin configurations.
If we ignore the most flexible way, then i could think of some pre-compiler stuff and we'd be good.
Maybe there is an even smarter way, that doesn't even need pre-compiler magic?
The text was updated successfully, but these errors were encountered: