Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or disable offline tests #1473

Open
LukasKorba opened this issue Aug 13, 2024 · 1 comment
Open

Fix or disable offline tests #1473

LukasKorba opened this issue Aug 13, 2024 · 1 comment

Comments

@LukasKorba
Copy link
Collaborator

3 offline tests are failing in the latest FFI branch changes. This is because viewing and spending keys are compared to some hardcoded values that were produced many years ago. The logic changed and we must update the hardcoded values.

@daira
Copy link
Contributor

daira commented Nov 18, 2024

It is preferable to disable broken tests if they are not promptly fixed.

Broken test suites have an extremely high cost in terms of lack of confidence that test failures are meaningful (the "cry wolf" effect). That normally far outweighs the value of the particular tests that are broken.

@daira daira changed the title Fix offline tests Fix or disable offline tests Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants