Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the SDK to not assume that the seed is available without user interaction #1508

Open
str4d opened this issue Nov 18, 2024 · 0 comments
Milestone

Comments

@str4d
Copy link
Collaborator

str4d commented Nov 18, 2024

Currently various public APIs of the SDK require passing the seed into them directly, making the assumption that the app can do so whenver that public API gets called (for example during Synchronizer initialization, we take the seed in order to perform any necessary wallet DB migrations). This won't be the case once we have hardware wallet support.

We need to ensure that:

  • APIs the SDK expects the app to call automatically / whenever necessary do not require the seed.
  • APIs that require the seed can be called either manually by the app, or have alternative pathways implemented and documented for use cases where the seed is not available on this device.
@str4d str4d added this to the iOS Zashi 1.3 milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant