Update to Netty 4.1.x #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you to hpfxd and PandaSpigot maintainers for the Netty patch Signed-off-by: BT (calcastor/mame) <[email protected]>
xism4
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch adds support for up to and including Java 11 by updating Netty to the latest upstream version. This patch is sourced from PandaSpigot, so thank you to hpfxd and other contributors to that project.
Previously, ViaVersion, Citizens, and ProtocolLib have had issues with this sort of patch. The newest versions of these plugins which still support 1.8.8 have resolved those issues, and other Paper patch sets which use this patch no longer include patches for those plugins. See discussion in #58.
The second patch is not directly related compatibility wise but seemed relevant nonetheless.
I've used a build of SportPaper with this patch when testing PGM locally for some months now with no issue, but I can't say I'm certain there would be 0 issues encountered in production without trying first.
Closes #58