Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce carpet patch with a config #63

Open
Anchor5178 opened this issue Mar 28, 2021 · 5 comments
Open

Reintroduce carpet patch with a config #63

Anchor5178 opened this issue Mar 28, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@Anchor5178
Copy link

Since 923ff1f was reverted with 5b5762f this issue is existing again.

This could be easily fixed by making https://github.com/Electroid/SportPaper/blob/master/patches/server/0191-Prevent-1.7-players-glitching-in-carpet.patch toggleable via the config.

Only AAC5 users have to disable this patch. AAC5 does not even support 1.7 so AAC5 users do not need this patch.

@Electroid Electroid changed the title Carpets while using AAC5 Reintroduce carpet patch with a config Mar 28, 2021
@Electroid Electroid added the enhancement New feature or request label Mar 28, 2021
@linsaftw
Copy link
Contributor

Or maybe you can use ViaVersion API to know if the player is using 1.7.

@Anchor5178
Copy link
Author

I do not understand how that should fix this issue since pure 1.8 servers are affected by it even though they do not need it.

@linsaftw
Copy link
Contributor

I do not understand how that should fix this issue since pure 1.8 servers are affected by it even though they do not need it.

Didn't it only affect 1.7 clients?

@Anchor5178
Copy link
Author

No, it also affects 1.8 players since the carpet height is set to 0 for all players.

@Pablete1234
Copy link
Contributor

With the patch, the hitbox is handled client-side, if you set it to 0 all players can freely walk on it, 1.7 players (due to their client) will be on y=0, and 1.8+ players will (again, due to their client) walk on y=0.0625.

The complaint is some anticheats will not treat this properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants