Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Commit 0f4ae57

Browse files
authored
1170 Fix import for svg used in openstreetmap (#1256)
## Summary - The link to the "plant.svg" image used in openstreetmap was broken due to the SVGs previously being moved to a different location - Fixed the link using an import statement <!-- Check relevant points but **please do not remove entries**. --> ## Basics <!-- These points need to be fulfilled for every PR. --> - [x] The PR is rebased with current master - [x] I added a line to [changelog.md](/doc/changelog.md) - [x] Details of what I changed are in the commit messages - [x] References to issues, e.g. `close #X`, are in the commit messages and changelog - [ ] The buildserver is happy <!-- If you have any troubles fulfilling these criteria, please write about the trouble as comment in the PR. We will help you, but we cannot accept PRs that do not fulfill the basics. --> ## Checklist <!-- For documentation fixes, spell checking, and similar none of these points below need to be checked. Otherwise please check these points when getting a PR done: --> - [ ] I fully described what my PR does in the documentation - [ ] I fixed all affected documentation - [ ] I fixed the introduction tour - [ ] I wrote migrations in a way that they are compatible with already present data - [ ] I fixed all affected decisions - [ ] I added automated tests or a [manual test protocol](../doc/tests/manual/protocol.md) - [ ] I added code comments, logging, and assertions as appropriate - [ ] I translated all strings visible to the user - [ ] I mentioned [every code or binary](https://github.com/ElektraInitiative/PermaplanT/blob/master/.reuse/dep5) not directly written or done by me in [reuse syntax](https://reuse.software/) - [ ] I created left-over issues for things that are still to be done - [ ] Code is conforming to [our Architecture](/doc/architecture) - [ ] Code is conforming to [our Guidelines](/doc/guidelines) - [ ] Code is consistent to [our Design Decisions](/doc/decisions) - [ ] Exceptions to any guidelines are documented ## First Time Checklist <!-- These points are only relevant when creating a PR the first time. --> - [ ] I have installed and I am using [pre-commit hooks](../doc/contrib/README.md#Hooks) - [ ] I am using [Tailwind CSS Linting](https://tailwindcss.com/blog/introducing-linting-for-tailwindcss-intellisense) ## Review <!-- Reviewers can copy&check the following to their review. Also the checklist above can be used. But also the PR creator should check these points when getting a PR done: --> - [ ] I've tested the code - [ ] I've read through the whole code - [ ] I've read through the whole documentation - [ ] I've checked conformity to guidelines - [ ] I've checked conformity to requirements - [ ] I've checked that the requirements are tested
2 parents 2275cc5 + e612543 commit 0f4ae57

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

doc/changelog.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ Syntax: `- short text describing the change _(Your Name)_`
6969
- Prevent propagating enft key on markdown editor _(Daniel Steinkogler)_
7070
- Enable deletion of selected plants via DEL shortcut _(Daniel Steinkogler)_
7171
- _()_
72-
- _()_
72+
- Fix link to Plant image for Openstreetmap _(Andrei Dinu)_
7373
- Add key combinations for map geometry _(Daniel Steinkogler)_
7474
- Add documentation for adding a new field to an entity _(Christoph Schreiner)_
7575
- _()_

frontend/src/features/landing_page/components/GeoMap.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { useTranslation } from 'react-i18next';
44
import { MapContainer, Marker, Popup, TileLayer } from 'react-leaflet';
55
import { useDarkModeStore } from '@/features/dark_mode';
66
import { PublicNextcloudImage } from '@/features/nextcloud_integration/components/PublicNextcloudImage';
7+
import plantSvg from '@/svg/plant.svg';
78
import 'leaflet/dist/leaflet.css';
89

910
const locations: Array<LatLngExpression> = [
@@ -21,7 +22,7 @@ export const GeoMap = () => {
2122
const darkMode = useDarkModeStore((state) => state.darkMode);
2223
const { t } = useTranslation(['geomap']);
2324
const myIcon = new Icon({
24-
iconUrl: '/plant.svg',
25+
iconUrl: plantSvg,
2526
iconSize: [40, 40],
2627
iconAnchor: [20, 40],
2728
popupAnchor: [0, 0],

0 commit comments

Comments
 (0)