Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Commit 26a74c5

Browse files
authored
agenda 02.01.2024 (#1143)
<!-- Check relevant points but **please do not remove entries**. --> ## Basics <!-- These points need to be fulfilled for every PR. --> - [ ] I added a line to [changelog.md](/doc/changelog.md) - [ ] The PR is rebased with current master. - [ ] Details of what you changed are in commit messages. - [ ] References to issues, e.g. `close #X`, are in the commit messages and changelog. - [ ] The buildserver is happy. <!-- If you have any troubles fulfilling these criteria, please write about the trouble as comment in the PR. We will help you, but we cannot accept PRs that do not fulfill the basics. --> ## Checklist <!-- For documentation fixes, spell checking, and similar none of these points below need to be checked. Otherwise please check these points when getting a PR done: --> - [ ] I have installed and I am using [pre-commit hooks](../doc/contrib/README.md#Hooks) - [ ] I fully described what my PR does in the documentation - [ ] I fixed all affected documentation - [ ] I fixed the introduction tour - [ ] I wrote migrations in a way that they are compatible with already present data - [ ] I fixed all affected decisions - [ ] I added automated tests or a [manual test protocol](../doc/tests/manual/protocol.md) - [ ] I added code comments, logging, and assertions as appropriate - [ ] I translated all strings visible to the user - [ ] I mentioned [every code or binary](https://github.com/ElektraInitiative/PermaplanT/blob/master/.reuse/dep5) not directly written or done by me in [reuse syntax](https://reuse.software/) - [ ] I created left-over issues for things that are still to be done - [ ] Code is conforming to [our Architecture](/doc/architecture) - [ ] Code is conforming to [our Guidelines](/doc/guidelines) - [ ] Code is consistent to [our Design Decisions](/doc/decisions) - [ ] Exceptions to any guidelines are documented ## Review <!-- Reviewers can copy&check the following to their review. Also the checklist above can be used. But also the PR creator should check these points when getting a PR done: --> - [ ] I've tested the code - [ ] I've read through the whole code - [ ] I've read through the whole documentation - [ ] I've checked conformity to guidelines
2 parents 1ffae7a + 2712174 commit 26a74c5

File tree

7 files changed

+134
-5
lines changed

7 files changed

+134
-5
lines changed

doc/changelog.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ Syntax: `- short text describing the change _(Your Name)_`
2525
- Added Meeting Agenda&Notes for 20.10. 9:00 _(Markus Raab, Samuel)_
2626
- Added Meeting Agenda&Notes for 27.10. 9:00 _(Markus Raab, Jannis)_
2727
- Added Meeting Agenda&Notes for 04.12. 9:00 _(Markus Raab, Daniel)_
28-
- Added Meeting Agenda for 11.12. 9:00 _(Markus Raab)_
29-
- Added Meeting Agenda for 18.12. 9:00 _(Markus Raab, Christoph)_
28+
- Added Meeting Agenda&Notes for 11.12. 9:00 _(Markus Raab)_
29+
- Added Meeting Agenda&Notes for 18.12. 9:00 _(Markus Raab, Christoph)_
30+
- Added Meeting Agenda&Notes for 27.12.2023 9:00 _(Markus Raab, Daniel)_
31+
- Added Meeting Agenda for 02.01.2024 9:00 _(Markus Raab, Daniel)_
3032
- _()_
3133
- _()_
3234
- _()_

doc/meetings/2023_12_27.md

+62
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
# Meeting 2023-12-27
2+
3+
## Attendees
4+
5+
- Markus
6+
- Yvonne
7+
- Daniel (Protocol done)
8+
9+
Break:
10+
11+
- Samuel
12+
- Jannis (Protocol done)
13+
- Christoph (Protocol done)
14+
- Moritz
15+
16+
## Buddies
17+
18+
- Moritz & Samuel
19+
- Daniel & Christoph & Jannis
20+
21+
## Agenda
22+
23+
- 09:00 welcome
24+
- Protocol: Daniel
25+
- Next meeting 2nd January 9:00 Chris, Daniel
26+
- [sprint plan](https://project.permaplant.net)
27+
28+
## Tasks for Everyone
29+
30+
To be done until **Sunday 31.12.2023**:
31+
32+
1. buddy talk topic: improvement of documentation
33+
2. do/update [sprint plan](https://project.permaplant.net)
34+
3. approve meeting PR [#1129](https://pull.permaplant.net/1129/files),
35+
check for [requested reviews](https://pulls.permaplant.net/?q=is%3Aopen+user-review-requested%3A%40me)
36+
37+
If possible/needed, do:
38+
39+
- create/update issues/tests (behavior driven) as needed for future tasks
40+
- get current issues, PRs and use cases (UC) [done](../usecases/README.md)
41+
- do reviews of PRs in main repo and submissions
42+
- submit a (short) text in submissions
43+
44+
## Individual Tasks
45+
46+
To be done until **Sunday 31.12.2023**:
47+
48+
- Daniel: PRs finish, continue drawing layer frontend, create drawing layer backend issue, check events performance, create layers and label layer issues
49+
50+
Break:
51+
52+
- Christoph: finish docu&scraper, plants hierarchy+relations
53+
- Moritz (?): create shade layer UC issues, group instead of layers, heat map, write about performance tests
54+
- Samuel: reviews, help others, documentation of unit tests
55+
- Jannis: push draft NC chat, PermaplanT: de+en plant names
56+
57+
## Meeting notes
58+
59+
- Polygons can be closed by clicking on start point
60+
- bezier anchors should always be shown when in editing mode of polygon
61+
- lines should be stored relative to starting point so that moving of elements can be done equally for each element
62+
- all error toasts should be automatically closed

doc/meetings/2024_01_02.md

+59
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
# Meeting 2023-01-02
2+
3+
## Attendees
4+
5+
- Markus
6+
- Yvonne
7+
- Daniel (Protocol done)
8+
9+
Break:
10+
11+
- Samuel
12+
- Jannis (Protocol done)
13+
- Christoph (Protocol done)
14+
- Moritz
15+
16+
## Buddies
17+
18+
- Moritz & Samuel
19+
- Daniel & Christoph & Jannis
20+
21+
## Agenda
22+
23+
- 09:00 welcome
24+
- Protocol: Daniel
25+
- [sprint plan](https://project.permaplant.net)
26+
27+
## Tasks for Everyone
28+
29+
To be done until **Friday 05.01.2024**:
30+
31+
1. buddy talk topic: improvement of documentation
32+
2. do/update [sprint plan](https://project.permaplant.net)
33+
3. approve meeting PR [#1129](https://pull.permaplant.net/1129/files),
34+
check for [requested reviews](https://pulls.permaplant.net/?q=is%3Aopen+user-review-requested%3A%40me)
35+
36+
If possible/needed, do:
37+
38+
- create/update issues/tests (behavior driven) as needed for future tasks
39+
- get current issues, PRs and use cases (UC) [done](../usecases/README.md)
40+
- do reviews of PRs in main repo and submissions
41+
- submit a (short) text in submissions
42+
43+
## Individual Tasks
44+
45+
To be done until **Friday 05.01.2024**:
46+
47+
- Daniel: PRs finish, continue drawing layer frontend, create drawing layer backend issue, check events performance, create layers and label layer issues
48+
49+
Break:
50+
51+
- Christoph: finish docu&scraper, plants hierarchy+relations
52+
- Moritz (?): create shade layer UC issues, group instead of layers, heat map, write about performance tests
53+
- Samuel: reviews, help others, documentation of unit tests
54+
- Jannis: push draft NC chat, PermaplanT: de+en plant names
55+
56+
## Meeting notes
57+
58+
- new layer: - modal with name and type (only drawing and labels) - new layer will be placed after enabled one - new layer is visible with 100% opacity
59+
- drawing: - arrows should be available

doc/usecases/assigned/create_layers.md

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
- User has opened the app.
1515
- **Main success scenario:**
1616
- The user can create a new drawing or labels layer.
17+
- These layers should give hints that they are not semantic for the application.
1718
- **Alternative scenario:**
1819
- **Error scenario:**
1920
- The user attempts to create the layer but the app is experiencing technical difficulties, e.g. too many layers were already created, and is unable to complete the request, displaying an error message.

doc/usecases/assigned/hydrology_layer.md

-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
For example: surface water runoff, natural reservoirs, gullies, rills, etc.
1919
This includes positioning the areas in the appropriate location.
2020
- Moisture or dry areas can be added by a small (rills) or big brush (surface water) to draw on the moisture layer.
21-
- Arrows can be used to indicate water flow.
2221
- **Alternative scenario:**
2322
- The user accidentally edits, moves or removes an element and uses undo to correct the mistake.
2423
- The user accidentally adds an element and deletes it with the "delete" or "undo" functionality.

doc/usecases/assigned/warnings_layer.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,10 @@
1414
The user has opened the app and has selected the warnings layer.
1515
- **Main success scenario:**
1616
- Warnings can be individual elements or connecting two elements, when modifying elements on the map:
17-
- shade mismatch
1817
- nearby antagonists
18+
- shade mismatch
19+
- hydrology mismatch
20+
- plant is on unsuitable zone
1921
- The user successfully adds, edits, moves and hides warnings.
2022
- **Alternative scenario:**
2123
The user accidentally adds, edits, moves or hides the wrong warnings and uses the app's undo function to correct the mistake.

doc/usecases/current/drawing_layer.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,14 @@
1414
The user has opened the app and has selected the drawing layer.
1515
- **Main success scenario:**
1616
- The user successfully adds, edits, moves, removes and deletes custom drawings of any color of following forms:
17-
- polygons (consisting of lines and bezier)
17+
- free drawings
18+
- ellipses
19+
- rectangles
20+
- polygons (consisting of lines and bezier helper-points, that can be created by dragging existing lines)
1821
- open without filling
1922
- closed with 3 different fillings
2023
- icons from Nextcloud
24+
- Arrows can be used to indicate water flow.
2125
- **Alternative scenario:**
2226
- The user accidentally edits, moves or removes an element and uses undo to correct the mistake.
2327
- The user accidentally adds an element and deletes it with the "delete" or "undo" functionality.

0 commit comments

Comments
 (0)