Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

partial dates not stored #723

Closed
2 tasks
markus2330 opened this issue Jul 27, 2023 · 5 comments
Closed
2 tasks

partial dates not stored #723

markus2330 opened this issue Jul 27, 2023 · 5 comments
Labels
bug Something isn't working needed later currently closed but might be needed later usability usability improvements wontfix This will not be worked on

Comments

@markus2330
Copy link
Contributor

markus2330 commented Jul 27, 2023

Steps to Reproduce the Problem

  • select a plant
  • change "removal date"'s month+year from the date picker (but no day)

Expected Result

error (that it successfully only stores month + year is not possible without custom date picker, see below)

Actual Result

feedback with green tick but nothing gets stored, when clicking again on the plant you see that there is no "removal date"

PermaplanT version

master

Operating System

Linux

Browser

Firefox

Versions of other relevant software/extensions

No response

Additional info/logs

No response

@markus2330 markus2330 added the bug Something isn't working label Jul 27, 2023
@markus2330
Copy link
Contributor Author

error message is fine, too

@Bushuo
Copy link
Contributor

Bushuo commented Jul 27, 2023

@markus2330
That won't work without a custom date picker.
The default one only supports full date specifications.
Everything else is just null.

If you try the same on the timeline there will be an error.
This is because null is a valid value in the context of the left Toolbar.

Also I am sure it stores null as soon as the green tick appears.

@markus2330 markus2330 added the usability usability improvements label Jul 27, 2023
@markus2330
Copy link
Contributor Author

Thx for the quick reply.

It is a usability problem. It shouldn't have a green tick when there isn't a valid date which it can save.

I had this problem only for the removal date, as the removal date didn't have any day entered. So implementing #724 would fix most of this usability problem.

@Bushuo
Copy link
Contributor

Bushuo commented Jul 27, 2023

Thx for the quick reply.

It is a usability problem. It shouldn't have a green tick when there isn't a valid date which it can save.

I had this problem only for the removal date, as the removal date didn't have any day entered. So implementing #724 would fix most of this usability problem.

The problem is, there is no way of figuring out what the value of the input is if it is only partial.
The value displayed on the monitor (inside the native date input) is part of a "closed shadow dom" which is a browser internal.

@markus2330 markus2330 added the wontfix This will not be worked on label Jul 27, 2023
@markus2330
Copy link
Contributor Author

Thx, tagged it as wontfix for now. Is #724 easy to fix?

@markus2330 markus2330 added the needed later currently closed but might be needed later label Sep 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working needed later currently closed but might be needed later usability usability improvements wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants