Skip to content
This repository has been archived by the owner on Apr 24, 2024. It is now read-only.

Add Pagination for plants search #914

Open
markus2330 opened this issue Sep 17, 2023 · 10 comments · May be fixed by #1335
Open

Add Pagination for plants search #914

markus2330 opened this issue Sep 17, 2023 · 10 comments · May be fixed by #1335
Assignees
@hatchla
Labels
enhancement New feature or request frontend changes in Typescript code

Comments

@markus2330
Copy link
Contributor

Describe the Bug

see also #913

Steps to Reproduce the Problem

search for plants

Expected Result

can be scrolled down for all results

Actual Result

only first page is shown

PermaplanT version

master

Operating System

any

Browser

any

Versions of other relevant software/extensions

No response

Additional info/logs

No response
@markus2330 markus2330 added the bug Something isn't working label Sep 17, 2023
@markus2330 markus2330 moved this to Current Sprint in PermaplanT Sep 17, 2023
@markus2330
Copy link
Contributor Author

@badnames was there already something done by you in this direction? Does the backend implement pagination?

@markus2330 markus2330 moved this from Current Sprint to Current Milestone in PermaplanT Sep 18, 2023
@markus2330 markus2330 removed the status in PermaplanT Oct 9, 2023
@markus2330 markus2330 moved this to Current Sprint in PermaplanT Oct 9, 2023
@markus2330
Copy link
Contributor Author

@badnames is there something still missing here?

@markus2330 markus2330 changed the title pagination for plants/seeds pagination for plants? Oct 23, 2023
@markus2330 markus2330 added the question Further information is requested label Oct 23, 2023
@badnames
Copy link
Member

Image

Pagination would be supported in the backend, but it is not used by the frontend.

Image

@markus2330 markus2330 removed the question Further information is requested label Oct 28, 2023
@markus2330
Copy link
Contributor Author

@badnames Please say which files you do screenshots from, otherwise it is an unnecessary difficulty for anyone working on this. Probably even better would be the feature from GitHub to link code.

Are there several places where the pagination would be needed or is it only the one search in the plants layer?

@markus2330 markus2330 changed the title pagination for plants? pagination for plants search in frontend missing Oct 28, 2023
@markus2330 markus2330 moved this from Current Sprint to Current Milestone in PermaplanT Oct 30, 2023
@markus2330 markus2330 moved this from Current Milestone to Current Sprint in PermaplanT Oct 30, 2023
@markus2330 markus2330 moved this from Current Sprint to Current Milestone in PermaplanT Oct 30, 2023
@markus2330 markus2330 moved this from Current Milestone to Current Sprint in PermaplanT Dec 4, 2023
@markus2330 markus2330 moved this from Current Sprint to Current Milestone in PermaplanT Dec 4, 2023
@markus2330 markus2330 moved this from Current Milestone to Current Sprint in PermaplanT Jan 15, 2024
@markus2330 markus2330 moved this from Current Sprint to Current Milestone in PermaplanT Jan 15, 2024
@markus2330 markus2330 assigned badnames and unassigned badnames Jan 29, 2024
@markus2330
Copy link
Contributor Author

@badnames ping, which file is this (frontend)?

This is the least important issue, I wanted to unassign you but the question should be answered first.

@badnames
Copy link
Member

You can find frontend/src/map_planning/layers/plant/components/PlantAndSeedSerach.tsx

@badnames badnames removed their assignment Mar 21, 2024
@markus2330 markus2330 added enhancement New feature or request and removed bug Something isn't working labels Apr 5, 2024
@markus2330
Copy link
Contributor Author

duplicate?

@markus2330 markus2330 moved this from Current Milestone to Current Sprint in PermaplanT Apr 15, 2024
@hatchla
Copy link
Contributor

hatchla commented Apr 18, 2024

duplicate?

Why should it be a duplicate?

@markus2330
Copy link
Contributor Author

I think this ended up by accident in this issue.

@hatchla hatchla moved this from Current Sprint to In Progress in PermaplanT Apr 22, 2024
@markus2330 markus2330 moved this from In Progress to Current Sprint in PermaplanT Apr 22, 2024
@hatchla hatchla moved this from Current Sprint to In Progress in PermaplanT Apr 23, 2024
@hatchla hatchla added the frontend changes in Typescript code label Apr 23, 2024
@hatchla hatchla changed the title pagination for plants search in frontend missing Add Pagination for plants search Apr 23, 2024
@hatchla
Copy link
Contributor

hatchla commented Apr 23, 2024

@markus2330 I would add a Page selector at the bottom of the search results for plants showing the current page and a back and forward button to navigate the results. Is this okay?

hatchla added a commit that referenced this issue Apr 23, 2024
@hatchla
feat(#914): Add pageNumber property to plantSearch
b8b4ba2
@hatchla hatchla linked a pull request Apr 23, 2024 that will close this issue
Add pagination to plantSearch #1335
Draft
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hatchla hatchla

Labels
enhancement New feature or request frontend changes in Typescript code
Projects
PermaplanT
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pagination to plantSearch ElektraInitiative/PermaplanT
3 participants
@markus2330 @badnames @hatchla