Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues about TypeScript definition #697

Open
iplus26 opened this issue Jan 2, 2018 · 1 comment
Open

Issues about TypeScript definition #697

iplus26 opened this issue Jan 2, 2018 · 1 comment

Comments

@iplus26
Copy link

iplus26 commented Jan 2, 2018

Description

TypeScript definitions of many components are wrong.

Reproduce Steps

For example, in definition of Input component, you write

    onChange?(e?: React.SyntheticEvent<HTMLInputElement>): void

in the real world, the component pass the string (value of input) to the onChange method, which should be

    onChange?(value: string): void

Another case, emptyText is not present in attributes of Table components, which is present in your docs.

Solution

Hopes there will be a full check of all definition and fix in TS .d.ts file. Or I may bring a pull request to fix the issues I ran into (which might be not complete)

@iplus26
Copy link
Author

iplus26 commented Jan 2, 2018

Related to the PR: #692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant