Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passive scroll listener #157

Open
nachogarcia opened this issue Oct 11, 2021 · 0 comments · May be fixed by #158
Open

Passive scroll listener #157

nachogarcia opened this issue Oct 11, 2021 · 0 comments · May be fixed by #158

Comments

@nachogarcia
Copy link

Using this library causes the following performance issue, reported in Google Lighthouse:

Does not use passive listeners to improve scrolling performance

I guess this would be simply fixed by using { passive: true } in

directive.scrollEventTarget.addEventListener('scroll', directive.scrollListener);

I don't think we would need to pass an option for this since the use for an infinite scroll is not to prevent scrolling.

nachogarcia added a commit to nachogarcia/vue-infinite-scroll that referenced this issue Oct 11, 2021
@nachogarcia nachogarcia linked a pull request Oct 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant