Skip to content
This repository has been archived by the owner on Feb 12, 2019. It is now read-only.

Check rb_setselect usage #156

Open
ariscop opened this issue Sep 21, 2015 · 1 comment
Open

Check rb_setselect usage #156

ariscop opened this issue Sep 21, 2015 · 1 comment
Milestone

Comments

@ariscop
Copy link
Contributor

ariscop commented Sep 21, 2015

6c2035a and similar changes need to be checked, libratbox's epoll loop is edge triggered but the code assumes it's level triggered

Since the change itself was to avoid an infinite loop, it may be best to change the event loop so this sort of code can be used to avoid callback recursion

Options:

  • Always call setselect before an fd might be written to, instead of after as rb_helper is currently doing
  • Level triggered + EPOLLONESHOT, might actually be the best option

There's about 80 rb_setselect calls that would need to be checked

@ariscop
Copy link
Contributor Author

ariscop commented Sep 21, 2015

This should be done with #94 since our libratbox is going to have less and less in common with charybdis's over time

@ariscop ariscop added this to the 7.0 milestone Sep 21, 2015
@ariscop ariscop changed the title Potential deadlocks Check rb_setselect usage Sep 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant