Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failing ccan tests on Alpine Linux #4847

Closed
jsarenik opened this issue Oct 7, 2021 · 1 comment
Closed

failing ccan tests on Alpine Linux #4847

jsarenik opened this issue Oct 7, 2021 · 1 comment
Labels
state::upstream This PR relates to an upstream dependency and needs to be submitted to the upstream repository.

Comments

@jsarenik
Copy link
Contributor

jsarenik commented Oct 7, 2021

Issue and Steps to Reproduce

First I get the ccan module names used in C-Lightning (e393791 of ccan rustyrussell/ccan@05ec8351) by running*:

cd ~/src/lightning
cd ccan/ccan
find . -type f -name _info | cut -b3- | sed 's|/_info$||' > /tmp/ccan-modules

Now let us test those modules*:

cd ~/src/ccan
git checkout init-2507-g05ec8351 # as referenced in lightning/ccan/README
make tools/ccanlint/ccanlint
while read module; do echo tools/ccanlint/ccanlint -s --deps-fail-ignore $module; done < /tmp/ccan-modules | sh -sxe

This issue is related to rustyrussell/ccan#67 and seemingly also to rustyrussell/ccan#59

* the output of finding ccan modules used in C-Lightning and the output of running the ccanlint command for each found module can be found at https://gist.github.com/jsarenik/b87eded7ae290ff50806fe9baefd8f3f

Practically a C-Lightning daemon is running on Alpine Linux with success (payments and forwards work) but these failing tests make me wonder that maybe something needs fixing. My assumption may be wrong. That is why this issue was created — to get feed-back.

@cdecker
Copy link
Member

cdecker commented Oct 20, 2021

This is strictly speaking not related to c-lightning, and must be fixed upstream.

@cdecker cdecker added the state::upstream This PR relates to an upstream dependency and needs to be submitted to the upstream repository. label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state::upstream This PR relates to an upstream dependency and needs to be submitted to the upstream repository.
Projects
None yet
Development

No branches or pull requests

2 participants