You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following from this conversation on Discord, @cdecker writes:
Sure, there are plenty of pre-commit plugins for that type of lint. A quick search surfaced https://github.com/compilerla/conventional-pre-commit for example.
I also wonder if we should remove some of our custom tooling in favor of better maintained conventional tools (shellcheck run, JSON schema format check, JSON schema validation, check that files were regenerated when needed, etc. currently there are loads of make targets that just check something in ci, when really we want to enforce them for new code. The upside would be that we check during commit, but the same rules can just be double checked in ci from the same config.
This issue represents the beginning of an initiative to improve standardization and offload some of the CI checks into the developer workflow, starting with the following brainstorm:
shellcheck run
JSON schema format check
Check regenerated files
lint commit messages and validate against accepted conventions
Python linting
The text was updated successfully, but these errors were encountered:
I added a first draft formatting the python files here: #7884
It took me a bit of time to figure out how to avoid an all-or-nothing formatting change, and luckily I found --from-ref and --to-ref which we can use to limit to just the PRs changed files. So we incrementally fix things up as we edit files.
Following from this conversation on Discord, @cdecker writes:
This issue represents the beginning of an initiative to improve standardization and offload some of the CI checks into the developer workflow, starting with the following brainstorm:
The text was updated successfully, but these errors were encountered: