Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup on large nodes is slow #8014

Open
rustyrussell opened this issue Jan 20, 2025 · 0 comments · May be fixed by #8019
Open

Startup on large nodes is slow #8014

rustyrussell opened this issue Jan 20, 2025 · 0 comments · May be fixed by #8019
Assignees
Milestone

Comments

@rustyrussell
Copy link
Contributor

@whitslack reported a 15 minute(!) startup time. Fortunately, he gave me a perf report, too:

-_start
               __libc_start_main
               0x7ff0cb565f59
               main
               |          
               |--91.30%--resend_closing_transactions
               |          |          
               |           --91.30%--drop_to_chain
               |                     |          
               |                      --91.30%--sign_and_send_last
               |                                |          
               |                                 --91.29%--wallet_extract_owned_outputs
               |                                           wallet_can_spend
               |                                           |          
               |                                           |--47.81%--scriptpubkey_p2tr_derkey

Sure enough, we loop through every key checking. This is silly, and we need to do better.

@rustyrussell rustyrussell added this to the v25.02 milestone Jan 20, 2025
@rustyrussell rustyrussell self-assigned this Jan 20, 2025
@rustyrussell rustyrussell linked a pull request Jan 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant