Error when setting the membership to 'all', getting 'permission denied'

[pukrai]

Even while this is just a demo for module development, I though I submitted this issue:

In file download/views/mod.download.php, line 163:

if ( ! in_array('all', $allowed) && ! in_array($group_id, $allowed))

should be

if ( ! in_array('0', $allowed) && ! in_array($group_id, $allowed))

since the "All" membership is defined in the database table as '0' and not as 'all'. Either that or modifying the part where the database is filled with new entries/ edited entries.

Keep up the great work!

[kevincupp]

Thanks, pukrai! Yes you're right, that if statement will miss that case. But by default, it is set to "all" in the database, but I guess when you update permissions, it gets set to "0". One quick fix would be to ADD ! in_array('0', $allowed) to the current if statement to catch all cases including "all", but I would say the solution should be to change the value in the dropdown like so:

$vars['member_groups_dropdown'] = array('all' => $this->EE->lang->line('all'));

That way, the data is consistently saved, and I don't think anything relies on member_access being set to zero. Does that sound good? Of course there's much more that SHOULD be done to this code now that I'm looking at it, it's easy to fall down the refactoring rabbit hole. :)