Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After deleting a peak, El Maven quits unexpectedly #1398

Open
kehj215 opened this issue Apr 5, 2021 · 4 comments
Open

After deleting a peak, El Maven quits unexpectedly #1398

kehj215 opened this issue Apr 5, 2021 · 4 comments
Assignees

Comments

@kehj215
Copy link

kehj215 commented Apr 5, 2021

Describe the bug
For some compounds, when I delete a peak in peak editor, El Maven quits/closes unexpectedly.

To Reproduce
Steps to reproduce the behavior:

  1. Select a bookmarked compound
  2. Click on peak editor
  3. double click, select "delete current peak"
  4. El Maven application quits/closes unexpectedly before applying edits or saving

Expected behavior
El Maven application does not quit/close unexpectedly.

Screenshots
No screenshots included.

System (please complete the following information):

  • MacOS Big Sur
  • v0.12.1-alpha

Additional context
none

@saif-el saif-el self-assigned this Apr 6, 2021
@saif-el
Copy link
Collaborator

saif-el commented Apr 6, 2021

@kehj215 I tried reproducing this using the two samples you had shared earlier, but could not get it to crash. Do you remember the m/z & rt of the peaks for which you are getting the issue?

@kehj215
Copy link
Author

kehj215 commented Apr 6, 2021

The m/z that is most problematic is 302.130/284.125 (CE: 16.67) RT 3.10. This one crashes the program nearly every time I delete a peak, but this issue is cropping up for multiple compounds.

@saif-el
Copy link
Collaborator

saif-el commented Apr 12, 2021

This is the chromatogram I see for that transition:

Screenshot 2021-04-12 at 9 08 32 AM

I do not see a peak at 3.10 minutes. The other two peaks (left and right) are not crashing the software for me. Could it be for one of the other samples that I do not have?

@kehj215
Copy link
Author

kehj215 commented Apr 12, 2021

Possibly. I also noticed that I can avoid crashing the software if I select multiple samples at once to delete peaks. The software only crashes if I choose a peak one sample at a time to delete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants