Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elunaengine not loading scripts when compiled #443

Closed
stefan4444333 opened this issue Aug 21, 2023 · 4 comments
Closed

Elunaengine not loading scripts when compiled #443

stefan4444333 opened this issue Aug 21, 2023 · 4 comments

Comments

@stefan4444333
Copy link

Hello, as of yesterday's date, when i was trying to compile a fresh ElunaTrinityWoltk server, i have an issue. I follow every step from the trinity installation guide and with every other core it works, but when i try to compile elunatrinitycore i stumble on a problem, to be more exact this:
image
In the LuaEngine.cpp. As i have read the code it is just some checks to see if the file is hidden, so i deleted it and the compilation worked and everything was built. But when i start my server i get this
image
Which is odd but i haven't thought anything about it, but the problem is when i try to load lua scripts, it doesn't load or show they have been loaded * since i have added some checks on most of my scripts to be sure that they have all loaded *. Can this be an issue from my side or is this an issue with elunaengine for trinitycore?

@Rochet2
Copy link
Member

Rochet2 commented Aug 21, 2023

The compilation error should now be fixed.

However, the issue with scripts and prints not working needs to be looked at.
TC made a few refactorings and changes recently that may have broken something on our side.

Seems that in addition to ELUNA_LOG* macros, we need to take a look if we use PQuery, PExecute, PAppend or similar database methods.

@stefan4444333
Copy link
Author

stefan4444333 commented Aug 21, 2023

I think they said to me what the problem was, instead of using %u, they use {} to print, or thats what i think it is, hope its helpful.

@Foereaper
Copy link
Member

ElunaLuaEngine/ElunaTrinityWotlk@aaa6e73

Commit that changed how strings are formatted. We either need to change the macro or we need to ifdef the outputs in Eluna

@Rochet2
Copy link
Member

Rochet2 commented Oct 14, 2023

Fixed in:

Thanks for reporting.

@Rochet2 Rochet2 closed this as completed Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants