Unit:GetFriendlyUnitsInRange( range ) not returning correct units

[Maha225]

Description: I did some testing in cmangos classic (latest from Niam5). It seems that the Unit:GetFriendlyUnitsInRange( range ) returns table of enemies and neutrals. Not friendlies.

[Rochet2]

All of the cores seem to use AnyFriendlyUnitInObjectRangeCheck as expected:

• Eluna/TrinityCore/UnitMethods.h

  Line 1037 in 46bed6d

  int GetFriendlyUnitsInRange(lua_State* L, Unit* unit)

• Eluna/CMangos/UnitMethods.h

  Line 1019 in 46bed6d

  int GetFriendlyUnitsInRange(lua_State* L, Unit* unit)

• Eluna/Mangos/UnitMethods.h

  Line 1254 in 46bed6d

  int GetFriendlyUnitsInRange(lua_State* L, Unit* unit)

However, it looks like the core side implementation on cmangos classic is not checking for friendliness:

• trinitycore: https://github.com/TrinityCore/TrinityCore/blob/fe2da02cc65a4c549bfea5709d7655c367dca1e9/src/server/game/Grids/Notifiers/GridNotifiers.h#L1007
• cmangos classic: https://github.com/cmangos/mangos-classic/blob/eaa38a9fe61a77d6a50fa448414cb35fd4f09f7a/src/game/Grids/GridNotifiers.h#L994
• mangos zero (classic): https://github.com/mangoszero/server/blob/28425a37e2326c721191895590798f90013f2fe6/src/game/WorldHandlers/GridNotifiers.h#L868

So it looks like a core side issue for cmangos classic.
Though it could be possible to also make a custom searcher on our side, it should probably be fixed on cmangos side.

[Rochet2]

Looks like in this commit they for some reason renamed the old friendly searcher and made a new one that doesnt actually check for friendliness

I submitted a ticket on cmangos side here

• 🐛 [Bug Report] AnyFriendlyUnitInObjectRangeCheck returns non-friends cmangos/issues#3563

[Maha225]

Oh it's on their end, well I am happy that you figured it out! Thank you!