Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegisterPlayerEvent _ON_KILLED_BY_CREATURE #451

Closed
betayi opened this issue Oct 29, 2023 · 5 comments
Closed

RegisterPlayerEvent _ON_KILLED_BY_CREATURE #451

betayi opened this issue Oct 29, 2023 · 5 comments
Assignees

Comments

@betayi
Copy link

betayi commented Oct 29, 2023

PLAYER_EVENT_ON_KILLED_BY_CREATURE = 8,

It seems not triggered ( not print ) while player killed by creature
--[code example]--
function OnPlayerDie(event, killer, killed)
print(killed:GetName().." killed")
end

RegisterPlayerEvent(8, OnPlayerDie)

other RegisterPlayerEvent works fine
at cmangostbc with LuaEngine@f8f97c55f79a7563c29b0a7c917babef96cdbe0c

@Niam5
Copy link
Contributor

Niam5 commented Oct 31, 2023

The core your having this issue with is CMaNGOS TBC right? If so ill look at since I'm the maintainer for those.

@Niam5 Niam5 self-assigned this Oct 31, 2023
@Niam5
Copy link
Contributor

Niam5 commented Nov 1, 2023

Please update your source files to 5279f5709d4a75f1a32bfe3e9411367a7feb7bb6 and retest for me please.

@betayi
Copy link
Author

betayi commented Nov 1, 2023

yes, it works,tyvm!

@betayi betayi closed this as completed Nov 2, 2023
@betayi
Copy link
Author

betayi commented Nov 10, 2023

this will make a core crash in sometimes #452

@betayi betayi reopened this Nov 10, 2023
@Niam5
Copy link
Contributor

Niam5 commented Nov 22, 2023

Duplicate of #452

@Niam5 Niam5 marked this as a duplicate of #452 Nov 22, 2023
@Niam5 Niam5 closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants