Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HandleStatModifier #495

Closed
Juggalo187 opened this issue Aug 30, 2024 · 3 comments
Closed

HandleStatModifier #495

Juggalo187 opened this issue Aug 30, 2024 · 3 comments

Comments

@Juggalo187
Copy link

Azerothcore Eluna module has the HandleStatModifier function, can that be added to trinitycore eluna?

@Foereaper
Copy link
Member

Not 1:1 no, but I can add some similar methods

@Foereaper
Copy link
Member

Foereaper commented Sep 1, 2024

The above commit adds the following methods for TC:

https://elunaluaengine.github.io/Unit/CanModifyStats.html
https://elunaluaengine.github.io/Unit/AddFlatStatModifier.html
https://elunaluaengine.github.io/Unit/AddPctStatModifier.html

Since the handlers on TC are not booleans and not a unified function like in AC, it is cleaner to separate them into their own methods and for you to check whether stat mods can be applied yourself.

@Juggalo187
Copy link
Author

Thanks, I had to manually apply it to ElunaTrinityWotlk but it works great.

I needed it for this script I've been wanting to make that I call Dungeonstats, when you kill a boss or optionally elites you gain a random stat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants