Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify supported Mac OS and Xcode version is used in build.rs #30

Open
repi opened this issue Nov 9, 2020 · 1 comment
Open

Verify supported Mac OS and Xcode version is used in build.rs #30

repi opened this issue Nov 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@repi
Copy link
Contributor

repi commented Nov 9, 2020

Currently one get a cryptic Objective C compile error if one is building with an unsupported Xcode, and with PR #26 we now require Xcode 12 (I think?) so more common to run into this. Would be much nicer if we can detect unsupported Xcode version in build.rs and fail there before starting the slow MoltenVK build.

Spawned off from #28 (comment)

image

Something you could take a quick look at @MarnixKuijs ?

@repi repi added the enhancement New feature or request label Nov 9, 2020
@repi repi changed the title Verify supported Xcode version is used in build.rs Verify supported Mac OS and Xcode version is used in build.rs Nov 9, 2020
@MarnixKuijs
Copy link
Member

MarnixKuijs commented Nov 10, 2020

Xcode 11 should still work. It at least did when I build with it (I have upgraded to 12 since then). It has mostly to do with the OS version your mac is running. With MoltenVK 1.1.0 its at least 10.15.4 afaik. IOS has a different version requirement

The problem I faced when I tried to add better error handling is that there is no easy way to get the version of IOS so the error handling would only work for MacOS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants