Skip to content

Commit 4ce7797

Browse files
committed
Release tickets after backfill assignments
1 parent cc7e683 commit 4ce7797

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

internal/app/backend/backend_service.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -447,9 +447,7 @@ func doAssignTickets(ctx context.Context, req *pb.AssignTicketsRequest, store st
447447
}
448448

449449
if err = store.DeleteTicketsFromPendingRelease(ctx, ids); err != nil {
450-
logger.WithFields(logrus.Fields{
451-
"ticket_ids": ids,
452-
}).Error(err)
450+
logger.WithError(err).WithField("ticket_ids", ids).Error("failed to delete tickets from pending release after updating assignment")
453451
}
454452

455453
return resp, nil

internal/app/frontend/frontend_service.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,10 @@ func (s *frontendService) AcknowledgeBackfill(ctx context.Context, req *pb.Ackno
374374
}
375375
}
376376

377+
if err = s.store.DeleteTicketsFromPendingRelease(ctx, associatedTickets); err != nil {
378+
logger.WithError(err).WithField("ticket_ids", associatedTickets).Error("failed to delete tickets from pending release after updating assignment during backfill ack")
379+
}
380+
377381
// Remove all tickets associated with backfill, because unassigned tickets are not found only
378382
err = s.store.UpdateBackfill(ctx, bf, []string{})
379383
if err != nil {

0 commit comments

Comments
 (0)