Skip to content

Commit 2d0c66c

Browse files
fix: query crates.io during release checks (vllm-project#271)
1 parent 91ed85f commit 2d0c66c

2 files changed

Lines changed: 9 additions & 2 deletions

File tree

‎.github/workflows/release-crates.yml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,12 @@ jobs:
134134
set -euo pipefail
135135
version="${{ steps.version.outputs.version }}"
136136
137-
if cargo info "agentic-server-core@$version" >/dev/null 2>&1; then
137+
if cargo info --registry crates-io "agentic-server-core@$version" >/dev/null 2>&1; then
138138
echo "::error::agentic-server-core $version is already published"
139139
exit 1
140140
fi
141141
142-
if cargo info "agentic-server@$version" >/dev/null 2>&1; then
142+
if cargo info --registry crates-io "agentic-server@$version" >/dev/null 2>&1; then
143143
echo "::error::agentic-server $version is already published"
144144
exit 1
145145
fi

‎tests/python/test_release_version.py‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,13 @@ def test_crate_release_dry_run_packages_server_against_the_local_core() -> None:
9595
assert (REPO_ROOT / "target" / "package" / f"agentic-server-{WORKSPACE_VERSION}.crate").is_file()
9696

9797

98+
def test_crate_release_published_version_checks_query_crates_io() -> None:
99+
workflow = CRATE_RELEASE_WORKFLOW.read_text(encoding="utf-8")
100+
published_check = next(block for block in _workflow_run_blocks(workflow) if "is already published" in block)
101+
102+
assert published_check.count("cargo info --registry crates-io") == 2
103+
104+
98105
def test_python_workflows_pin_build_tools_and_manylinux_artifact_contract() -> None:
99106
release_workflow = RELEASE_WORKFLOW.read_text(encoding="utf-8")
100107
python_workflow = PYTHON_WORKFLOW.read_text(encoding="utf-8")

0 commit comments

Comments
 (0)