Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopNavBar layout handling + adjustments #183

Open
1 of 11 tasks
justin-b-yee opened this issue Aug 7, 2024 · 4 comments · May be fixed by #275
Open
1 of 11 tasks

TopNavBar layout handling + adjustments #183

justin-b-yee opened this issue Aug 7, 2024 · 4 comments · May be fixed by #275
Assignees
Labels

Comments

@justin-b-yee
Copy link
Contributor

justin-b-yee commented Aug 7, 2024

Specs

We want to more easily configure adding components to the navbar, along with a few adjustments. Add a new prop sideButtons to take a list of components. These components will be rendered on the right side in the order they were provided from left-to-right.

Dependencies

Note: The component changes can be worked on without these - these are just needed for the final enciv home navbar change.

<TopNavBar
    ... // existing props
    sideButtons = [],
>

Tasks

Civil Pursuit Repo

  • Layout adjustment: Make the logo, menu selections, and buttons vertically levelled (see mockup). Right now, the selections appear lower than the logo, and the logo is significantly taller.
  • Fix any spacing/margin discrepancies, and ensure everything looks good relative to the mockup.
  • If components are provided in the sideButtons prop, render them in left-to-right order, justified on the navbar's right side.
  • In mobile mode, render the sideButtons vertically below the menu selections in the order provided from top to bottom.
  • Use this new prop to render the previously hard-coded donate button.

Enciv Home Repo

  • In the enciv home repo app.js, edit the TopNavWrap function to use the new navbar props and match the mockup.

Figma

Image

  • In condensed mode, the sideButtons should appear below the list, with 1 rem of extra gap. We don't have figma for this.

Image

New tasks as of 1/21/2025

  • In the Make Sure Dropdowns Appear test, when "Our Work" is hovered, the menu items Work 1 and Work 2 need to be visible, currently items below the menu bar div are hidden.

Image

Image

@ddfridley
Copy link
Contributor

@justin-b-yee I added something for the condensed mode. Take a look. I moved it to todo but you can still edit if necessary.

@Chenxuan-Liu Chenxuan-Liu self-assigned this Aug 26, 2024
@ddfridley
Copy link
Contributor

@Chenxuan-Liu This one is assigned to you. I know you are moving on to a new job, shall we just move this on back to ToDo? Thanks.

@agrawalashita
Copy link

interested in working on this as an OPT volunteer

@ddfridley
Copy link
Contributor

@agrawalashita great. It has been assigned to you and I have sent you an invite to the enciv developers team on github. Please accept it, so you can push your branch and move the issue to "ready to review" when ready. Thanks!

@agrawalashita agrawalashita moved this from Todo to In Progress in EnCiv Cross Repo Project Management Jan 20, 2025
@agrawalashita agrawalashita moved this from In Progress to Ready for Review in EnCiv Cross Repo Project Management Jan 20, 2025
@ddfridley ddfridley linked a pull request Jan 21, 2025 that will close this issue
@ddfridley ddfridley moved this from Ready for Review to In Progress in EnCiv Cross Repo Project Management Jan 21, 2025
@agrawalashita agrawalashita linked a pull request Jan 23, 2025 that will close this issue
@ddfridley ddfridley moved this from In Progress to Ready for Review in EnCiv Cross Repo Project Management Feb 3, 2025
@ddfridley ddfridley moved this from Ready for Review to In Progress in EnCiv Cross Repo Project Management Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants