Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hangup Button #268

Open
ddfridley opened this issue Sep 4, 2020 · 3 comments
Open

Hangup Button #268

ddfridley opened this issue Sep 4, 2020 · 3 comments
Assignees
Labels
React UI Design User Interface Design task/issue

Comments

@ddfridley
Copy link
Contributor

We need a hangup button that is consistent with the new design of the other buttons.

We will need an SVG file, that is similar in format to the other buttons -- see #177 and https://github.com/EnCiv/undebate/files/4935390/updated.buttons.zip for the other buttons

@ddfridley ddfridley added UI Design User Interface Design task/issue React labels Sep 4, 2020
@ddfridley
Copy link
Contributor Author

Kristen is working on this but I don't have her in github yet

@kawill
Copy link
Collaborator

kawill commented Sep 4, 2020

A potential solution:
Maybe name the button closer to what it does ‘Delete Recording’ and have a confirmation modal with an overlay to draw the candidate’s attention
desktop - delete recording
desktop - delete recording overlay
delete-recording-buttons.zip
Figma Link: https://www.figma.com/file/wCHdJXu75RphBsOTs6LSyf/CC-9-2-20?node-id=5%3A8

@ddfridley
Copy link
Contributor Author

@Jack-Pham This is the Issue where I'd like you to help with making the popup look like what's above.
The branch is https://github.com/EnCiv/undebate/tree/recorder-setup
The file to work in is: https://github.com/EnCiv/undebate/blob/recorder-setup/app/components/hangup-button.jsx
Please make a separate branch for this.

One comment about the above picture, I like the way the current popup is near the button that you click on, rather than in the middle of the screen.

I'm going to be slow to be behind on testing and merging this week because of family medical care issues. I'm trying to get recorder-setup into master, but I have to finish the testing, and I'm waiting the improved mic-meter/mic and camera selector component that Dana is working on. Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
React UI Design User Interface Design task/issue
Projects
None yet
Development

No branches or pull requests

2 participants