Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CED-1819 update vscode extensions #1489

Merged
merged 1 commit into from
Aug 28, 2024
Merged

CED-1819 update vscode extensions #1489

merged 1 commit into from
Aug 28, 2024

Conversation

tomleo
Copy link
Member

@tomleo tomleo commented Aug 22, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Lets make sure we only suggest vscode extensions that work well with vue3/nuxt3
  • I just limited the suggestions and made sure to use the right vue extension

🥼 Testing

  • All extensions suggested I'm using locally

🧐 Feedback Requested / Focus Areas

  • 🤷

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@tomleo tomleo changed the base branch from main to esds-3.0-vue3-primevue August 22, 2024 23:16
@tomleo tomleo requested a review from mpleroux August 22, 2024 23:17
@tomleo tomleo merged commit eb17f2c into esds-3.0-vue3-primevue Aug 28, 2024
1 check passed
@tomleo tomleo deleted the update-vscode-extensions branch August 28, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpleroux mpleroux mpleroux approved these changes

@ericdouglaspratt ericdouglaspratt Awaiting requested review from ericdouglaspratt ericdouglaspratt is a code owner

@nathanielwarner nathanielwarner Awaiting requested review from nathanielwarner nathanielwarner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomleo @mpleroux