-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CED-1815 Fix accessibility issue in v3 EsRadioButton #1506
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Radio button is a pretty standard name across the entire industry (Wikipedia) that has a specific etymology. It's also called that in the ESDS 2.0 Figma.
I'd recommend keeping the name, at least on the docs site and in the UI.
Oh weird, bootstrap seems to follow the actual markup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments on the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing that the linting check is failing (maybe eslint and prettier are fighting?) but otherwise LGTM! π
π Linked issue
β Type of change
π Description
EsRadioButton
toEsRadioInput
as there's no buttons involved with this component. The odd naming is an artifact of the radio component it's wrapping PrimeVue RadioButtonEsRadioInputGroup
component to match how we've been usingb-form-radio-group
see JIRA for comtextEsRadioInput
examples inEsRadioInputGroup
components to ensure fieldset & legend are present (for a11y reasons)π₯Ό Testing
π§ Feedback Requested / Focus Areas
b-form-group
as well. I started to implement a similar component, but that seemed out-of-scope for this. Something we may want to implement down the line though.π Checklist