Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule tweak #1514

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Rule tweak #1514

merged 2 commits into from
Sep 5, 2024

Conversation

tomleo
Copy link
Member

@tomleo tomleo commented Sep 5, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Small tweak for nested ternary

🥼 Testing

🧐 Feedback Requested / Focus Areas

  • Personally I really like the ternary syntax, particularly for conditions around classes being applied

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@tomleo tomleo changed the base branch from main to esds-3.0-vue3-primevue September 5, 2024 15:52
nathanielwarner
nathanielwarner requested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it looks like there's a linting problem with this change somehow? Not sure what's going on there

@tomleo
Copy link
Member Author

tomleo commented Sep 5, 2024

Actually, it looks like there's a linting problem with this change somehow? Not sure what's going on there

A single extra space 😓, fixed.

@tomleo tomleo merged commit b366166 into esds-3.0-vue3-primevue Sep 5, 2024
1 check passed
@tomleo tomleo deleted the rule-tweak branch September 5, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielwarner nathanielwarner nathanielwarner approved these changes

@ericdouglaspratt ericdouglaspratt Awaiting requested review from ericdouglaspratt ericdouglaspratt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomleo @nathanielwarner