Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add EsErrorPage v3 #1516

Merged
merged 4 commits into from
Sep 6, 2024
Merged

feat: add EsErrorPage v3 #1516

merged 4 commits into from
Sep 6, 2024

Conversation

hroth1994
Copy link
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Create EsErrorPage and associated docs page that uses fullWidthComponent layout

🥼 Testing

Tested locally at http://localhost:8500/organisms/error-page

🧐 Feedback Requested / Focus Areas

  • General

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@swarmia Swarmia
Copy link

swarmia bot commented Sep 6, 2024

✅  Linked to Task CED-1784 · Create v3 EsErrorPage
➡️  Part of Epic CED-1339 · Build Vue 3 design system [LC]

ericdouglaspratt
ericdouglaspratt requested changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing.

es-ds-components/components/es-error-page.vue Outdated Show resolved Hide resolved
ericdouglaspratt
ericdouglaspratt approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@hroth1994 hroth1994 merged commit a8b733e into esds-3.0-vue3-primevue Sep 6, 2024
1 check passed
@hroth1994 hroth1994 deleted the ced-1784-EsErrorPage-v3 branch September 6, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdouglaspratt ericdouglaspratt ericdouglaspratt approved these changes

@tomleo tomleo Awaiting requested review from tomleo tomleo is a code owner

@nathanielwarner nathanielwarner Awaiting requested review from nathanielwarner nathanielwarner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hroth1994 @ericdouglaspratt