Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iris Shaders #154

Open
purrloftruth opened this issue Oct 6, 2024 · 5 comments
Open

Iris Shaders #154

purrloftruth opened this issue Oct 6, 2024 · 5 comments
Labels
fixed in next release Fixed in the next release. If the issue this is on is closed, the fix is already released Suggestion

Comments

@purrloftruth
Copy link

URL

https://www.curseforge.com/minecraft/mc-mods/irisshaders

Why would you like the mod added?

Shaders are pretty.
Screenshot with Complementary Reimagined and Distant Horizons

Notes:

  • Iris for 1.21.1 is still in beta.
  • Iris is not supported by Embeddium. The mainline version of Sodium now has an official NeoForge port (in beta). Like Embeddium, it has inline FRAPI support without adding Indium separately.
  • I've seen a number of other modpacks offer the Complementary Shaders with the Euphoria patches by default, and if you don't have other preferences these seem like a good default choice.
  • The screenshot I took above uses the Complementary Reimagined shaders and also is using Distant Horizons. (I'm not sure how you all would feel about having DH as a mod in the pack by default, so I won't worry about filing a request for that yet)
@MuteTiefling
Copy link
Contributor

We generally prefer leaving this up to the player to decide if they want it.

@purrloftruth
Copy link
Author

I get that 100%. From my perspective, shipping Iris in-pack either with no shaders included or with shaders disabled in the default config has these benefits:

  • It reduces friction for the user (this is likely to be one of the mods that users add on to the modpack most)
  • It means the user is not modifying the modpack in the case they need to file an issue (more users than usual will likely modify the modpack because they want to add this mod)
  • It clearly signifies that Iris, and no other mod, is the supported method of using shaders with E10 (in the situation there are future forks/competitors; I'm not sure there are any alternatives at the moment)

Are these relevant considerations (or am I overthinking things)?

@NielsPilgaard
Copy link
Collaborator

NielsPilgaard commented Oct 6, 2024

Those are very good points 🤔

@theboo
Copy link

theboo commented Oct 6, 2024

I think the bigger issue might be that we're currently shipping embeddium, and there's currently no possible way to load shaders with embeddium installed in the pack as the bridge mod Monocle is stuck in license hell trying to support iris(embeddium doesn't work with iris directly, and oculus is dead due to iris existing natively.

So when people ask how to enable shaders in this pack we'll have to tell them to remove embeddium and install sodium/iris... Then they'll have to remove embeddium every time they update the pack, and we're updating fairly frequently

@NielsPilgaard
Copy link
Collaborator

I think the bigger issue might be that we're currently shipping embeddium, and there's currently no possible way to load shaders with embeddium installed in the pack as the bridge mod Monocle is stuck in license hell trying to support iris(embeddium doesn't work with iris directly, and oculus is dead due to iris existing natively.

So when people ask how to enable shaders in this pack we'll have to tell them to remove embeddium and install sodium/iris... Then they'll have to remove embeddium every time they update the pack, and we're updating fairly frequently

Edit:this sent as soon as I logged on... Idk what happened but most of this is covered by purrloftruth lol

I've been meaning to swap up Embeddium for Sodium anyway, this is a good extra incentive.

@NielsPilgaard NielsPilgaard added the fixed in next release Fixed in the next release. If the issue this is on is closed, the fix is already released label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in next release Fixed in the next release. If the issue this is on is closed, the fix is already released Suggestion
Projects
None yet
Development

No branches or pull requests

4 participants