-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--no_stats causing different results in some cases in new VEP #1034
Comments
Could you fix this, please? |
Hi @Stikus, Thanks for bringing this to our attention. I can reproduce the issue, and I'll let you know when we have a fix in place. Kind Regards, |
Hi! Any news here? How critical is this inconsistency? |
Hello, any progress about this problem? |
Hi @serge2016 and @Stikus, |
Very pity( Hope to see it soon! |
Hello, any news? I've found closed PR related to this issue: #1044 We cannot use latest VEP releases in our production due to this problem because without |
Until the issue is fixed, as a workaround you could try a solution similar to https://github.com/ntm/grexome-TIMC-Secondary/blob/master/3_runVEP.pl |
Dear authors! |
Hi @serge2016 Rather than repeating, can I point you to my answer on ticket 1066 (#1066) as it also applies to this issue. |
Dear colleagues, @aparton @dglemos @nuno-agostinho @jamie-m-a, a year more is gone. I really think this bug is critical! What can I do to help? I have no idea, how the |
Hey @serge2016, We have not advanced further on this issue, but I'll prioritise this. I am sorry for the inconvenience. Kind regards, |
Thank you, @nuno-agostinho Hope to see updates soon! It is really critical bug for us... |
Dear @nuno-agostinho, |
Hey @Stikus and @serge2016! I was playing with a quick fix to the issue (#1427), but it makes VEP with From what I can gather, these issues happen only when using I am trying to find a good way to fix this, but the release 110 is imminent (so probably not going in for 110). Sorry for the inconvenience. Best, |
Hello @nuno-agostinho, have you found the fix for this issue? |
Hello, @jamie-m-a !!! Could you help with this, please? |
Hi @serge2016 from what we've been able to discover, the --no_stats option when used with --hgvs doesn't properly calculate the hgvs in all cases. The only workaround we've found is to recalculate hgvs at the end, but this will negate the speed improvement offered by running with --no_stats. Unfortunately we don't have capacity in the team at present to fix this issue, so I'd suggest running without --no_stats and look at parallelisation options (such as using the Nextflow VEP pipeline) to improve annotation speed. |
Thank you! I understand, but hope you'll find a possibility to fix this. |
Describe the issue
We continue digging into differences (#1031) caused by
--no_stats
workaround from #818 and found something more interesting.Two files with
--no_stats
and without it differs not only withMAX_AF_POPS
filed (this happening independently of this flag) but in several other lines.Moreover - when we use our old VEP (99) - we don't have this problem (here is working version):
Additional information
When we compared files from 99 version of VEP with 104 version, we found that old files are nearly equal with run result without
--no_stats
- that was another evidence that this flag causing problems in new version.System
Full VEP command line
Data files (if applicable)
Our input file (with little truncated header):
Results:
VEP 99 (with our without
--no_stats
- they are equal):VEP 104 (with
--no_stats
):VEP 104 (without
--no_stats
):And here are the differences in transcripts:
First two pair are from first line from VCF and here is the different parts -
G/TE|acg/acGGAg
without--no-stats
andG/GR|acg/ggGAGg
with. But this isGAA
insertion, notGAG
- its strange at least.Last pair has differences not only in amino acids and codons, but in
Consequence
,SIFT
,PolyPhen
too.The text was updated successfully, but these errors were encountered: