Rust doesn't use the Bitcode loader, so don't build it#2405
Merged
wsmoses merged 4 commits intoEnzymeAD:mainfrom Sep 16, 2025
Merged
Rust doesn't use the Bitcode loader, so don't build it#2405wsmoses merged 4 commits intoEnzymeAD:mainfrom
wsmoses merged 4 commits intoEnzymeAD:mainfrom
Conversation
Member
|
this is fine, but also could you add the fix for the bcloader on llvm21 (presumably BC->setTargetTriple(""); becomes BC->setTargetTriple(llvm::Triple("")); ) |
wsmoses
approved these changes
Aug 7, 2025
Member
|
also probably add LLVM 21 integration test CI, so then this will be caught in the future? |
Collaborator
Author
|
I've added your fix, it works locally from LLVM15 onwards, but somehow Julia seems unhappy. So I just limited the fix to 21+. |
ZuseZ4
force-pushed
the
disable-bc-load
branch
from
9225129 to
a8487db
Compare
Member
|
can you also add the LLVM21 test to confirm this builds as expected? |
Collaborator
Author
|
We don't have LLVM-21 CI, and touching enzyme CI is a bit beyond the time I have atm. |
Member
|
it should just be adding it to the relevant yml file |
ZuseZ4
force-pushed
the
disable-bc-load
branch
from
a8487db to
6dbee0e
Compare
Collaborator
Author
|
ping @wsmoses this keeps comming up |
Collaborator
Author
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust recently updated to llvm 21: rust-lang/rust#143684
This caused build failures in the BCLoader.
The failure should be fixed independently, but afaik on the Rust side we don't use the BCloader, so I think there is no reason to build it in the first place. With this patch, rust bootstrap works again, so I merged rust-lang#29 for now, but would like to upstream it.
Relatedly, I should probably disable the following:
(The toolchain size increase of ~9 MiB through Enzyme currently is the only reason why std::autodiff isn't enabled in nightly by default, so that's somewhat relevant.)