Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desideratum: download XML mini-corpus from search results #34

Open
gabrielbodard opened this issue Jul 18, 2017 · 6 comments
Open

Desideratum: download XML mini-corpus from search results #34

gabrielbodard opened this issue Jul 18, 2017 · 6 comments
Assignees
Milestone

Comments

@gabrielbodard
Copy link

Another suggestion was that when a user has serched for a term or browsed through various facets (or both) to find a subset of inscriptions in the search interface, they be given the option to download a ZIP file containing the XML files of just those inscriptions that appear in the search results list. This would enable them to create a mini corpus of just 1st century religious texts, or just texts on marble from Rome, or just pre-5th century texts mentioning Agathe Tyche, or whatever.

@gabrielbodard
Copy link
Author

This would be a subtask of the general "download button for zip file of all EpiDoc files in corpus" task, which doesn't seem to be a ticket. @ajenhl shall I make a ticket for that, or is it already known about and in hand? (If not, I guess it's higher priority than this one, which may just move to "Future Work"…?

@ajenhl
Copy link

ajenhl commented Nov 24, 2017

No need for such a ticket; I've just committed the general download link to the inscriptions index.

@ajenhl
Copy link

ajenhl commented Nov 29, 2017

As a note about this particular issue, it would require changing the way search results are handled. At the moment, the pagination is handled by Solr, which returns a set number of results at a time. In order to have a download of all documents returned by a search, it would need to return all rows at once and the pagination then work on that subset. There's obviously a performance penalty there, though how much of one depends on a couple of factors (how many results there are in total, how much information is returned for each document).

Just something to bear in mind.

@gabrielbodard
Copy link
Author

Is there a setting for how many results are returned? E.g. (20|50|100|all) with a speed caveat on all!

If so we could just say download current results list, and leave it to the user to decide if they need a longer list..?

@ajenhl
Copy link

ajenhl commented Nov 30, 2017

Solr doesn't have an "all results" option. Values are set in assets/queries/solr/facet_query.xml (for the main search), where users are also directed to go when adding/removing facets, etc.

It occurs to me that the link to download a ZIP file of all the works referenced in the search results can perform its own query, with the rows parameter set to a very high value, and so nothing about the structure of the search and pagination be changed. That will be easy to implement.

@gabrielbodard
Copy link
Author

@ajenhl this was never implemented for EFES 1.0, was it? Let's reassign to 2.0, unless you think it is trivial enough that you'd do it in your spare time in the interim? ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants