From cb58c2c06881e99ed2af40f7b61580e501e8cf85 Mon Sep 17 00:00:00 2001 From: Matthew Cotton Date: Mon, 22 Jan 2024 12:16:42 +1100 Subject: [PATCH 1/3] adding a signalling test action to master so it can be run in the signalling_tester branch --- .github/workflows/run-signalling-tests.yml | 41 ++++++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 .github/workflows/run-signalling-tests.yml diff --git a/.github/workflows/run-signalling-tests.yml b/.github/workflows/run-signalling-tests.yml new file mode 100644 index 00000000..8ec8de7e --- /dev/null +++ b/.github/workflows/run-signalling-tests.yml @@ -0,0 +1,41 @@ +name: Run signalling tests + +on: + push: + branches: ['signalling_tester'] + paths: ['SignallingWebServer/**'] + pull_request: + branches: ['signalling_tester'] + paths: ['SS_Test/**'] + +jobs: + + build: + runs-on: ubuntu-latest + defaults: + run: + working-directory: ./ + + permissions: + contents: write + + steps: + - name: "Checkout source code" + uses: actions/checkout@v3 + + - uses: actions/setup-node@v3 + with: + node-version: '18.x' + registry-url: 'https://registry.npmjs.org' + + - name: Run signalling server + working-directory: ./SignallingWebServer + run: ./platform_scripts/bash/run_local.sh & + + - name: Install library deps + working-directory: ./SS_Test + run: npm ci + + - name: Run frontend lib tests + working-directory: ./SS_Test + run: npm run start From 556ecc5df39070dd19ca11a35961bf515bdcada2 Mon Sep 17 00:00:00 2001 From: Matthew Cotton Date: Mon, 22 Jan 2024 12:17:59 +1100 Subject: [PATCH 2/3] Allowing signalling test action to be manually triggered --- .github/workflows/run-signalling-tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/run-signalling-tests.yml b/.github/workflows/run-signalling-tests.yml index 8ec8de7e..a5bc1a6d 100644 --- a/.github/workflows/run-signalling-tests.yml +++ b/.github/workflows/run-signalling-tests.yml @@ -1,6 +1,7 @@ name: Run signalling tests -on: +on: + workflow_dispatch: push: branches: ['signalling_tester'] paths: ['SignallingWebServer/**'] From f0fd72768c73da2b9388f6063e709de453deee82 Mon Sep 17 00:00:00 2001 From: Matthew Cotton Date: Tue, 20 Feb 2024 15:13:29 +1100 Subject: [PATCH 3/3] Fixed incorrect settings setup with SettingOption --- Frontend/library/package-lock.json | 4 ++-- Frontend/library/src/Config/SettingOption.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Frontend/library/package-lock.json b/Frontend/library/package-lock.json index 76e764d5..ae9ca3dc 100644 --- a/Frontend/library/package-lock.json +++ b/Frontend/library/package-lock.json @@ -1,12 +1,12 @@ { "name": "@epicgames-ps/lib-pixelstreamingfrontend-ue5.4", - "version": "0.0.1", + "version": "0.0.3", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "@epicgames-ps/lib-pixelstreamingfrontend-ue5.4", - "version": "0.0.1", + "version": "0.0.3", "license": "MIT", "dependencies": { "sdp": "^3.1.0" diff --git a/Frontend/library/src/Config/SettingOption.ts b/Frontend/library/src/Config/SettingOption.ts index ba2aed77..a4c43b72 100644 --- a/Frontend/library/src/Config/SettingOption.ts +++ b/Frontend/library/src/Config/SettingOption.ts @@ -24,7 +24,7 @@ export class SettingOption< // eslint-disable-next-line @typescript-eslint/no-empty-function defaultOnChangeListener: (changedValue: unknown, setting: SettingBase) => void = () => { /* Do nothing, to be overridden. */ } ) { - super(id, label, description, [defaultTextValue], defaultOnChangeListener); + super(id, label, description, defaultTextValue, defaultOnChangeListener); this.options = options; const urlParams = new URLSearchParams(window.location.search);